On 3 May 2016 at 07:32, Christophe Milard <[email protected]> wrote:
> Please don't do that: It will just create an extra rebase on my "running > things in process mode " patch series which replaces all this (and > therefore delete these also) > > We need a test in helper for it then :) we dont want the full Monarch API to go out with an untested API from the test suite perspective, Krishna, Christoph any chance you can add one since you both care about the API? Mike > Christophe. > > On 2 May 2016 at 14:01, Krishna Garapati <[email protected]> > wrote: > >> >> >> On 2 May 2016 at 13:47, Mike Holmes <[email protected]> wrote: >> >>> odph_linux_process_fork is not used by any ODP example or test, it is >>> also >>> untested by the helper test suite. >>> >> Just for the note, we use this api currently in our nginx_ofp app. >> >>> >>> odph_linux_process_fork is a wrapper for odph_linux_process_fork_n so >>> just delete this, the impact if there are any users is very small. >>> >> Agree, need a minor update in the app. >> >> /Krishna >> >>> >>> Signed-off-by: Mike Holmes <[email protected]> >>> --- >>> helper/include/odp/helper/linux.h | 18 ------------------ >>> helper/linux.c | 10 ---------- >>> 2 files changed, 28 deletions(-) >>> >>> diff --git a/helper/include/odp/helper/linux.h >>> b/helper/include/odp/helper/linux.h >>> index 7a6504f..a68f269 100644 >>> --- a/helper/include/odp/helper/linux.h >>> +++ b/helper/include/odp/helper/linux.h >>> @@ -80,24 +80,6 @@ int odph_linux_pthread_create(odph_linux_pthread_t >>> *pthread_tbl, >>> */ >>> void odph_linux_pthread_join(odph_linux_pthread_t *thread_tbl, int num); >>> >>> - >>> -/** >>> - * Fork a process >>> - * >>> - * Forks and sets CPU affinity for the child process. Ignores 'start' >>> and 'arg' >>> - * thread parameters. >>> - * >>> - * @param[out] proc Pointer to process state info (for output) >>> - * @param cpu Destination CPU for the child process >>> - * @param thr_params Linux helper thread parameters >>> - * >>> - * @return On success: 1 for the parent, 0 for the child >>> - * On failure: -1 for the parent, -2 for the child >>> - */ >>> -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, >>> - const odph_linux_thr_params_t *thr_params); >>> - >>> - >>> /** >>> * Fork a number of processes >>> * >>> diff --git a/helper/linux.c b/helper/linux.c >>> index 24e243b..a181322 100644 >>> --- a/helper/linux.c >>> +++ b/helper/linux.c >>> @@ -183,16 +183,6 @@ int odph_linux_process_fork_n(odph_linux_process_t >>> *proc_tbl, >>> return 1; >>> } >>> >>> -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, >>> - const odph_linux_thr_params_t *thr_params) >>> -{ >>> - odp_cpumask_t mask; >>> - >>> - odp_cpumask_zero(&mask); >>> - odp_cpumask_set(&mask, cpu); >>> - return odph_linux_process_fork_n(proc, &mask, thr_params); >>> -} >>> - >>> int odph_linux_process_wait_n(odph_linux_process_t *proc_tbl, int num) >>> { >>> pid_t pid; >>> -- >>> 2.7.4 >>> >>> _______________________________________________ >>> lng-odp mailing list >>> [email protected] >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
