I don't know how one can speak for "future readers" (whoever they might be). I have no objection to the edit, but we should say that it's our rule, not concern for posterity's sensibilities that motivates it. :)
On Thu, May 5, 2016 at 8:58 AM, Mike Holmes <[email protected]> wrote: > We shouldn't mention the tool that found the issue in the subject, future > readers of git only want to know what happened. > It can be changed on merge to test: packet: remove unused values > > > On 4 May 2016 at 20:21, Bill Fischofer <[email protected]> wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by removing >> unused values. >> >> Signed-off-by: Bill Fischofer <[email protected]> >> --- >> test/validation/packet/packet.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/test/validation/packet/packet.c >> b/test/validation/packet/packet.c >> index 7c9622f..bf8d9f4 100644 >> --- a/test/validation/packet/packet.c >> +++ b/test/validation/packet/packet.c >> @@ -1159,7 +1159,7 @@ void packet_test_align(void) >> CU_ASSERT(odp_packet_align(&pkt, 0, pkt_len, 0) < 0); >> >> offset = seg_len - 5; >> - pkt_data = odp_packet_offset(pkt, offset, &seg_len, NULL); >> + (void)odp_packet_offset(pkt, offset, &seg_len, NULL); >> >> /* Realign for addressability */ >> CU_ASSERT(odp_packet_align(&pkt, offset, >> @@ -1167,8 +1167,7 @@ void packet_test_align(void) >> >> /* Alignment doesn't change packet length or contents */ >> CU_ASSERT(odp_packet_len(pkt) == pkt_len); >> - aligned_data = odp_packet_offset(pkt, offset, >> - &aligned_seglen, NULL); >> + (void)odp_packet_offset(pkt, offset, &aligned_seglen, >> NULL); >> _packet_compare_offset(pkt, offset, >> segmented_test_packet, offset, >> aligned_seglen); >> -- >> 2.5.0 >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
