Hi, Bill This is not introduced by this patch but in earlier code:
*platform/linux-generic/odp_cpumask.c* *init_default_worker_cpumask()* *init_default_control_cpumask():* *...default mask initialization if not specified by odp_init_global()* */** * * If three or more CPUs, reserve CPU 0 for kernel, * reserve CPU 1 for control, and * reserve remaining CPUs for workers */Thanks and Best Regards, Yi* On 20 May 2016 at 22:26, Bill Fischofer <[email protected]> wrote: > This patch looks good, however when I run the thread helper test I get > this output: > > bill@Ubuntu15:~/linaro/review/helper/test$ ./thread > System can only support 2 threads and not the 16 requested > default cpu mask: 0xC > default num worker threads: 2 > the first CPU: 2 > new cpu mask: 0xC > new num worker threads: 2 > > Worker thread on CPU 2 > Worker thread on CPU 3 > > I'm running on a 4 CPU VM, so I'd expect one control thread and that would > leave room for three workers, however it seems we somehow ignore CPU 0 so > CPU 1 gets assigned as control and that leaves only 2 for workers. > > I'm not sure if that's the fault of this patch, but we certainly don't > want to be losing CPU 0. I'd assume the initial thread would by default be > considered a control thread. > > On Fri, May 20, 2016 at 4:06 AM, Yi He <[email protected]> wrote: > >> Hi, this is a proposal solution for ODP-427: how to guarantee cpu locality >> schematic of odp_cpu_cycles() and its relates. >> >> Discussions lead to the direction of "providing methods to set affinity in >> odp helper and do it by application on demand." >> >> So this is the patch: >> 1, Add APIs in helper/linux (with test). >> 2, Set main process affinity for all test program in odp_cunit_common >> library. >> >> please suggest, thanks and best regards, Yi >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
