On 23 May 2016 at 17:34, Christophe Milard <[email protected]> wrote:
> > > On 23 May 2016 at 17:31, Ola Liljedahl <[email protected]> wrote: > >> >> >> On 23 May 2016 at 17:28, Christophe Milard <[email protected]> >> wrote: >> >>> This is for linux helpers: in odp linux, just pthreads and processes are >>> supported as odpthreads.(well actually processes are not supported yet, but >>> we head to it). >>> >> You can use C and C++ threads in Linux as well. You just need a >> conforming compiler. >> > > Not through the helper at this stage. When calling > odph_odpthread_create(), the odpthread is created as either pthread > (default) or forked process (--odph_proc option). > So at this stage C and C++ threads are not supported by the helpers. > OK that's fine if this is all encapsulated in to ODP/Linux helpers. That should be possible to change without interfering too much with the actual ODP implementation in use. > > >> >> >>> If we support something else in some future, we'll update the comment >>> then. >>> >>> Christophe >>> >>> On 23 May 2016 at 17:23, Ola Liljedahl <[email protected]> wrote: >>> >>>> >>>> >>>> On 23 May 2016 at 17:04, Christophe Milard < >>>> [email protected]> wrote: >>>> >>>>> Signed-off-by: Christophe Milard <[email protected]> >>>>> --- >>>>> helper/include/odp/helper/linux.h | 6 +++--- >>>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/helper/include/odp/helper/linux.h >>>>> b/helper/include/odp/helper/linux.h >>>>> index 01c348d..2e89833 100644 >>>>> --- a/helper/include/odp/helper/linux.h >>>>> +++ b/helper/include/odp/helper/linux.h >>>>> @@ -73,13 +73,13 @@ typedef struct { >>>>> >>>>> /** The odpthread starting arguments, used both in process or thread >>>>> mode */ >>>>> typedef struct { >>>>> - odph_odpthread_linuxtype_t linuxtype; >>>>> - odph_odpthread_params_t thr_params; /*copy of thread start >>>>> parameter*/ >>>>> + odph_odpthread_linuxtype_t linuxtype; /**< process or pthread >>>>> */ >>>>> >>>> ODP threads might not be pthreads. There are many implementations of >>>> threads. >>>> Aren't we trying to tell the application if we are using a >>>> single-process (memory space) or multi-process model? >>>> Let's report this and only this. >>>> >>>> + odph_odpthread_params_t thr_params; /**< odpthread start >>>>> parameters */ >>>>> } odph_odpthread_start_args_t; >>>>> >>>>> /** Linux odpthread state information, used both in process or thread >>>>> mode */ >>>>> typedef struct { >>>>> - odph_odpthread_start_args_t start_args; >>>>> + odph_odpthread_start_args_t start_args; /**< start >>>>> arguments */ >>>>> int cpu; /**< CPU ID */ >>>>> int last; /**< true if last >>>>> table entry */ >>>>> union { >>>>> -- >>>>> 2.5.0 >>>>> >>>>> _______________________________________________ >>>>> lng-odp mailing list >>>>> [email protected] >>>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>>>> >>>> >>>> >>> >> > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
