Hi Ruslan, We discussed this today and request that you break this patch up into multiple patch sets since it looks like you're trying to do a number of unrelated things here. Removing the bash dependencies looks good and should be it's own patch. I'm assuming the intent here is to work with any shell?
It's not clear whether the OCTEON patch is still needed as we've had a number of recent patches in this area. As for the musl support, that should be it's own patch with a better explanation of whether this is simply enabling support for musl or using it as a default. odp-linux makes very limited use of libc to begin with and what use there is is not in performance paths so it's not clear that musl would provide any measurable benefit. Thanks. On Tue, Jun 28, 2016 at 1:43 AM, Ruslan Babayev <[email protected]> wrote: > Signed-off-by: Ruslan Babayev <[email protected]> > --- > configure.ac | 4 ++-- > scripts/get_impl_str.sh | 2 +- > scripts/git_hash.sh | 5 ++--- > 3 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index f3952db..efde412 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -83,7 +83,7 @@ AC_SUBST([ARCH_DIR]) > ########################################################################## > # Warn on the defaults if arch is undefined > ########################################################################## > -if test "${ARCH_DIR}" == "undefined"; > +if test "${ARCH_DIR}" = "undefined"; > then > echo "ARCH_DIR is undefined, please add your ARCH_DIR based on > host=${host}" > exit 1 > @@ -112,7 +112,7 @@ AC_SUBST([platform_with_platform], > ["platform/${with_platform}"]) > # Run platform specific checks and settings > ########################################################################## > IMPLEMENTATION_NAME="" > -if test "${with_platform}" == "linux-generic"; > +if test "${with_platform}" = "linux-generic"; > then > m4_include([./platform/linux-generic/m4/configure.m4]) > m4_include([./test/platform/linux-generic/m4/configure.m4]) > diff --git a/scripts/get_impl_str.sh b/scripts/get_impl_str.sh > index d765a53..1448a3f 100755 > --- a/scripts/get_impl_str.sh > +++ b/scripts/get_impl_str.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/bin/sh > > if [ -z ${1} ]; then > echo "should be called with a path" > diff --git a/scripts/git_hash.sh b/scripts/git_hash.sh > index 336eb01..823cb48 100755 > --- a/scripts/git_hash.sh > +++ b/scripts/git_hash.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/bin/sh > > if [ -z ${1} ]; then > echo "should be called with a path" > @@ -9,8 +9,7 @@ ROOTDIR=${1} > if [ -d ${ROOTDIR}/.git ]; then > hash=$(git --git-dir=${ROOTDIR}/.git describe --match > 'v[0-9]*\.[0-9]*\.[0-9]*\.[0-9]*'\ > | tr -d "\n") > - if [[ $(git --git-dir=${ROOTDIR}/.git diff --shortstat 2> > /dev/null \ > - | tail -n1) != "" ]]; then > + if [ -n "$(git --git-dir=${ROOTDIR}/.git diff --shortstat > 2>/dev/null | tail -n1)" ]; then > dirty=.dirty > fi > > -- > 2.7.4 > > _______________________________________________ > lng-odp mailing list > [email protected] > https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
