From: Bill Fischofer [mailto:[email protected]] Sent: Thursday, July 07, 2016 5:08 PM To: Mike Holmes <[email protected]> Cc: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]>; [email protected] Subject: Re: [lng-odp] [PATCH] linux-generic: byteorder: avoid bitfield order doxygen omissions
On Thu, Jul 7, 2016 at 9:05 AM, Mike Holmes <[email protected]> wrote: If it can't be done in a backwards compatible way this has to go to TigerMoth. Do we patch in Monarch and fix properly there ? This should be fixed in Monarch. I'd prefer to fix this without reverting Petri's header restructure patch series, but that's what introduced this problem. <<reply>> Only way to fix it, is to remove doxygen documentation of ODP_LITTLE_ENDIAN_BITFIELD when it is not defined, and vice versa with ODP_BIG_ENDIAN_BITFIELD. I'm not sure why doxygen was happy before ... both BIG and LITTLE were documented, but only one of those should have been #defined. I'd prefer API fix to Monarch, so that ENDIAN and BITFIELD defines work the same way. -Petri
