More detailed flow on how to figure out the number

https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

On 29 November 2016 at 13:09, Mike Holmes <mike.hol...@linaro.org> wrote:

>
>
> On 29 November 2016 at 11:32, Maxim Uvarov <maxim.uva...@linaro.org>
> wrote:
>
>> Default is abi compat mode, all interface functions changed,
>> so increase first number of .so
>>
>> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org>
>> ---
>>  configure.ac | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index b460a65..e7b8f8a 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -3,7 +3,7 @@ AC_PREREQ([2.5])
>>  # Set correct API version
>>  ###########################################################
>> ###############
>>  m4_define([odpapi_generation_version], [1])
>> -m4_define([odpapi_major_version], [11])
>> +m4_define([odpapi_major_version], [12])
>>  m4_define([odpapi_minor_version], [0])
>>  m4_define([odpapi_point_version], [0])
>>  m4_define([odpapi_version],
>> @@ -30,10 +30,10 @@ AM_SILENT_RULES([yes])
>>  ###########################################################
>> ###############
>>  # Set correct platform library version
>>  ###########################################################
>> ###############
>> -ODP_LIBSO_VERSION=111:0:0
>> +ODP_LIBSO_VERSION=112:0:0
>>  AC_SUBST(ODP_LIBSO_VERSION)
>>
>> -ODPHELPER_LIBSO_VERSION=110:0:1
>> +ODPHELPER_LIBSO_VERSION=112:0:0
>>
>
> I am not a lib expert but I expected this to be 111.1.2 becasue there was
> no API Change and it is backwards compatible
>
> mike@mike-desktop:~/git/odp$ git df -w --stat
> origin/monarch_lts..origin/master helper
>  helper/Makefile.am |  2 ++
>  helper/chksum.c    | 25 ++++++++++++++++---------
>  2 files changed, 18 insertions(+), 9 deletions(-)
>
> using info from
> https://autotools.io/libtool/version.html
>
>
> So for *current*, *revision* and *age*.
>
>    -
>
>    Always increase the revision value.
>    -
>
>    Increase the current value whenever an interface has been added,
>    removed or changed.
>    -
>
>    Increase the age value only if the changes made to the ABI are
>    backward compatible.
>
>
> So I get 111 < rule two nothing changed in the interface :1 < rule one
> always +1 :2 < rule three, looks like the code is compatible
>
> I also used the debian tool to check and it appears to show 100%
> compatibility with master (the default GIT_URL/GIT_BRANCH)
>
> mike@mike-desktop:~/git/check-odp$ COMPARE_URL=https://git.
> linaro.org/lng/odp.git COMPARE_BRANCH=v1.11.0.0_monarch ./diff-abi.sh
>
> See here
> http://people.linaro.org/~mike.holmes/diff-abi/libodphelper-compat_report.
> html
>
> Experts please weigh in :)
>
>
>
>
>>  AC_SUBST(ODPHELPER_LIBSO_VERSION)
>>
>>  # Checks for programs.
>> --
>> 2.7.1.250.gff4ea60
>>
>>
>
>
> --
> Mike Holmes
> Program Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
> "Work should be fun and collaborative, the rest follows"
>
>
>


-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"

Reply via email to