Seems to resolve my drvshm crash issue.

Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com>


> -----Original Message-----
> From: Christophe Milard [mailto:christophe.mil...@linaro.org]
> Sent: Tuesday, November 29, 2016 4:46 PM
> To: maxim.uva...@linaro.com; Savolainen, Petri (Nokia - FI/Espoo)
> <petri.savolai...@nokia-bell-labs.com>; bill.fischo...@linaro.org; lng-
> o...@lists.linaro.org
> Cc: Christophe Milard <christophe.mil...@linaro.org>
> Subject: [API-NEXT PATCH] test: drvshm: removing invalid test
> 
> The test trying to free a unallocated address is now erroneous since
> ODP is using ishm too: unknown drvshm addresses may well be valid ODP
> addresses, in which case the test frees someone else memory!
> The test is simply suppressed.
> 
> Signed-off-by: Christophe Milard <christophe.mil...@linaro.org>
> ---
>  test/common_plat/validation/drv/drvshmem/drvshmem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/test/common_plat/validation/drv/drvshmem/drvshmem.c
> b/test/common_plat/validation/drv/drvshmem/drvshmem.c
> index 559c55d..0247a03 100644
> --- a/test/common_plat/validation/drv/drvshmem/drvshmem.c
> +++ b/test/common_plat/validation/drv/drvshmem/drvshmem.c
> @@ -135,8 +135,6 @@ void drvshmem_test_basic(void)
>       shared_test_data->foo = TEST_SHARE_FOO;
>       shared_test_data->bar = TEST_SHARE_BAR;
> 
> -     CU_ASSERT(odpdrv_shm_free_by_address((char *)shared_test_data - 1) <
> 0);
> -
>       thrdarg.numthrds = odp_cpumask_default_worker(&unused, 0);
> 
>       if (thrdarg.numthrds > MAX_WORKERS)
> --
> 2.7.4

Reply via email to