Ooops Clang. forgot this one.... will go through this. thanks... On 7 December 2016 at 13:21, Bill Fischofer <bill.fischo...@linaro.org> wrote:
> On Wed, Dec 7, 2016 at 1:19 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: > > > > On 7 December 2016 at 01:19, Bill Fischofer <bill.fischo...@linaro.org> > > wrote: > >> > >> After applying this series ./configure fails: > >> > >> ./configure > >> .... > >> checking for GCC atomic builtins... yes > >> checking libconfig.h usability... no > >> checking libconfig.h presence... no > >> checking for libconfig.h... no > >> checking for pkg-config... /usr/bin/pkg-config > >> checking pkg-config is at least version 0.9.0... yes > >> checking for PKGCONFIG... no > >> configure: error: Package requirements (libconfig >= 1.3.2) were not > met: > >> > >> No package 'libconfig' found > >> > >> Consider adjusting the PKG_CONFIG_PATH environment variable if you > >> installed software in a non-standard prefix. > >> > >> Alternatively, you may set the environment variables PKGCONFIG_CFLAGS > >> and PKGCONFIG_LIBS to avoid the need to call pkg-config. > >> See the pkg-config man page for more details. > >> > >> Is there a new DEPENDENCIES add that's needed? > > > > > > Yes: patch " linux-gen: init: adding configuration file parsing" (in this > > series) > > needs libconfig-dev. The patch adds libconfig-dev in DEPENDENCIES too. > > Is there anything else which needs to be done when an extra dependency is > > added? > > Thanks for your attention, > > > > Christophe > > Ok, thanks! I should have found that. After installing libconfig-dev > ./configure now works, however with: > > make CC=clang I get: > > ... > CC drv_atomic.lo > CC drv_barrier.lo > CC drv_driver.lo > In file included from drv_driver.c:11: > In file included from ./include/odp/drv/driver.h:21: > ../../include/odp/drv/spec/driver.h:126:3: error: redefinition of typedef > 'odpdrv_enum_class_t' is a C11 feature [-Werror,-Wtypedef- > redefinition] > } odpdrv_enum_class_t; > ^ > ../../include/odp/drv/spec/driver.h:85:36: note: previous definition is > here > typedef struct odpdrv_enum_class_t odpdrv_enum_class_t; > ^ > ../../include/odp/drv/spec/driver.h:151:3: error: redefinition of typedef > 'odpdrv_enum_t' is a C11 feature [-Werror,-Wtypedef-redefinition] > } odpdrv_enum_t; > ^ > ../../include/odp/drv/spec/driver.h:86:30: note: previous definition is > here > typedef struct odpdrv_enum_t odpdrv_enum_t; > ^ > ../../include/odp/drv/spec/driver.h:182:3: error: redefinition of typedef > 'odpdrv_enumerated_dev_t' is a C11 feature > [-Werror,-Wtypedef-redefinition] > } odpdrv_enumerated_dev_t; > ^ > ../../include/odp/drv/spec/driver.h:87:40: note: previous definition is > here > typedef struct odpdrv_enumerated_dev_t odpdrv_enumerated_dev_t; > ^ > ../../include/odp/drv/spec/driver.h:253:3: error: redefinition of typedef > 'odpdrv_driver_t' is a C11 feature [-Werror,-Wtypedef-redefinition] > } odpdrv_driver_t; > ^ > ../../include/odp/drv/spec/driver.h:88:32: note: previous definition is > here > typedef struct odpdrv_driver_t odpdrv_driver_t; > ^ > 4 errors generated. > Makefile:934: recipe for target 'drv_driver.lo' failed > make[1]: *** [drv_driver.lo] Error 1 > make[1]: Leaving directory > '/home/bill/linaro/drvregister/platform/linux-generic' > Makefile:498: recipe for target 'all-recursive' failed > make: *** [all-recursive] Error 1 > > > > > >> > >> On Tue, Dec 6, 2016 at 8:23 AM, Christophe Milard > >> <christophe.mil...@linaro.org> wrote: > >> > Since V2: > >> > -function odp_load_driver removed. replaced by config file. (Petri, > FF) > >> > -configuration file "odp.conf" added. Configuration file is: > >> > 1) as specified in env variable ODP_SYSCONFIG_FILE (which can be > >> > "none"). > >> > 2) ./odp.conf > >> > 3) $(prefix)/etc/odp.conf > >> > -test removed: will be sent in a separate patch as many questions > >> > remains. > >> > -All libdl tests removed: libdl is assumed to always be on linux > >> > (Maxim) > >> > > >> > Since V1: > >> > -enum names prefixed by ODPDRV (Yi) > >> > -better commit message for last patch (Christophe) > >> > -typo fix (Christophe) > >> > > >> > This patch series puts the driver initialisation framework in place: > >> > Loadable modules (*.so) are given in the odp.conf file added here. > >> > Once loaded, the drivers init function (declared as __constructor__) > >> > calls the ODP odp_driver_register() intialialisation function which, > >> > at this stage does nothing (just print an error message). > >> > odp_driver_register() is of course part of the driver interface > (south). > >> > > >> > Christophe Milard (5): > >> > drv: adding driver registration interface (stub) > >> > linux-gen: adding enum, devio and driver registration interface > (stub) > >> > linux-gen: init: adding configuration file parsing > >> > test: preventing odp.conf loading for tests > >> > linux-gen: drv_drivers: loading modules from config file > >> > > >> > DEPENDENCIES | 2 +- > >> > configure.ac | 4 +- > >> > include/odp/drv/spec/driver.h | 311 > >> > ++++++++++++++++++++++++ > >> > include/odp_drv.h | 1 + > >> > platform/Makefile.inc | 1 + > >> > platform/linux-generic/Makefile.am | 3 + > >> > platform/linux-generic/drv_driver.c | 84 +++++++ > >> > platform/linux-generic/include/odp/drv/driver.h | 27 ++ > >> > platform/linux-generic/include/odp_internal.h | 5 + > >> > platform/linux-generic/m4/configure.m4 | 12 + > >> > platform/linux-generic/m4/odp_drivers.m4 | 11 + > >> > platform/linux-generic/odp_init.c | 77 ++++++ > >> > test/Makefile.inc | 4 +- > >> > 13 files changed, 538 insertions(+), 4 deletions(-) > >> > create mode 100644 include/odp/drv/spec/driver.h > >> > create mode 100644 platform/linux-generic/drv_driver.c > >> > create mode 100644 platform/linux-generic/include/odp/drv/driver.h > >> > create mode 100644 platform/linux-generic/m4/odp_drivers.m4 > >> > > >> > -- > >> > 2.7.4 > >> > > > > > >
