Le 12/13/2016 à 08:46 AM, Christophe Milard a écrit : > On 12 December 2016 at 15:52, Mike Holmes <mike.hol...@linaro.org> wrote: > >> Signed-off-by: Mike Holmes <mike.hol...@linaro.org> >> --- >> configure.ac | 14 ++++++++++++++ >> helper/Makefile.am | 2 +- >> 2 files changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index 20ec479..39c040d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -154,6 +154,19 @@ fi >> ODP_CFLAGS="$ODP_CFLAGS -DIMPLEMENTATION_NAME=$IMPLEMENTATION_NAME" >> >> ############################################################ >> ############## >> +# Determine which os to build helpers for >> +########################################################### >> ############### >> +AC_ARG_WITH([os], >> + [AS_HELP_STRING([--with-os=os], >> + [select platform to be used, default linux])], >> > Shouldn't it be " select OS to be used, default linux" ??? > Here again, we hit the platform vs OS question, but if the platform and OS > are different things, then it should be OS here! If there are the same > thing, then why not using the -with-platform which we already have... > > I guess we know what an OS is... but what is a platform? > -The HW in which ODP is running (implies memory size limitation, different > pktio interfaces...). This is my understanding, but odp/pltaform/linux-gen > is missleading and should be called odp/os/linux-gen > - A couple HW/OS, as this patch seems to imply? > > Christophe > > + [], We have the case here at Kalray where we have a single platform (mppa) but 2 supported OS depending on what the user wants to do (non ODP compliant code). The OS has no impact on the platform, but changes the helpers.
So no the platform isn't fully OS dependent. And yes the help string should be "select OS to be used" Nicolas
