On 09.03.2017 17:15, Bill Fischofer wrote:
> Checkpatch issue with this part:
>
> WARNING: Missing a blank line after declarations
> #38: FILE: platform/linux-generic/include/odp_crypto_internal.h:66:
> +uint32_t bytes;
> +const EVP_MD *evp_md;
>
> total: 0 errors, 1 warnings, 0 checks, 205 lines checked
There is no 'after declarations' there. It's rather a checkpatch error. See:
> diff --git a/platform/linux-generic/include/odp_crypto_internal.h
> b/platform/linux-generic/include/odp_crypto_internal.h
> index f85b76ea..515cefaa 100644
> --- a/platform/linux-generic/include/odp_crypto_internal.h
> +++ b/platform/linux-generic/include/odp_crypto_internal.h
> @@ -60,16 +60,10 @@ struct odp_crypto_generic_session {
> } cipher;
>
> struct {
> - union {
> - struct {
> - uint8_t key[16];
> - uint32_t bytes;
> - } md5;
> - struct {
> - uint8_t key[32];
> - uint32_t bytes;
> - } sha256;
> - } data;
> + uint8_t key[EVP_MAX_KEY_LENGTH];
> + uint32_t key_length;
> + uint32_t bytes;
> + const EVP_MD *evp_md;
> crypto_func_t func;
> } auth;
> };
--
With best wishes
Dmitry
