> -----Original Message-----
> From: lng-odp [mailto:[email protected]] On Behalf Of
> Dmitry Eremin-Solenikov
> Sent: Monday, March 06, 2017 5:37 PM
> To: [email protected]
> Subject: [lng-odp] [PATCH] linux-generic: crypto: properly handle errors
> in packet copy
>
> Add proper handling for errors returned by odp_packet_copy_from_pkt().
>
> Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
> ---
> odp_packet_len(param->pkt));
> + if (odp_unlikely(odp_packet_copy_from_pkt(param-
> >out_pkt,
> +
> 0,
> +
> param->pkt,
> +
> 0,
> +
> odp_packet_len(param->pkt)) < 0)) {
> + ODP_DBG("Copy failed.\n");
> + return -1;
> + }
> _odp_packet_copy_md_to_packet(param->pkt, param-
> >out_pkt);
> odp_packet_free(param->pkt);
> param->pkt = ODP_PACKET_INVALID;
Did you run checkpatch on this patch. It should warn you about over 80 char
lines.
perl scripts/checkpatch.pl <patch>
To avoid long line do e.g.
ret = odp_packet_copy_from_pkt();
if(ret) ...
-Petri
