> -----Original Message----- > From: Bill Fischofer [mailto:[email protected]] > Sent: Wednesday, March 29, 2017 6:01 PM > To: Bogdan Pricope <[email protected]> > Cc: Maxim Uvarov <[email protected]>; Savolainen, Petri (Nokia - > FI/Espoo) <[email protected]>; lng-odp-forward <lng- > [email protected]> > Subject: Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet > checksum control > > On Wed, Mar 29, 2017 at 8:38 AM, Bogdan Pricope > <[email protected]> wrote: > > > > What about: > > > > void odp_packet_out_l3_csum_override(odp_packet_t pkt, odp_bool_t > compute); > > That's a bit of a mouthful. Since chksum insertion only makes sense on > output that's implied here, so I think Petri's name choices seem clear > and natural.
Also the same function will used to control IPSEC inner packet checksum insertion (and other potential tunnel offloads). So, it's not only for packet out, but generally control between "insert" vs "do not insert" checksum. -Petri
