Yes, also patch should pass code coverage. That is set on github and it should warn that there are function which are not used marked with red color. We are trying to remove all not used functions from the code. So that should go with code where it's used.
Maxim. On 10 April 2017 at 13:20, Savolainen, Petri (Nokia - FI/Espoo) < [email protected]> wrote: > > > From: Kevin Wang [mailto:[email protected]] > Sent: Monday, April 10, 2017 12:24 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: Kevin Wang <[email protected]>; [email protected] > Subject: Re: [lng-odp] [PATCH] linux-gen: packet: add pkt_to_buffer_hdr() > function > > Currently no. But will be used in the future if scalable scheduler is > merged. Two files loop.c and odp_packet_io.c will use this conversion. > > Kevin > > > Why? The patch should include also usage - so that we can see why the > change is needed / done this way vs. some other way. Is it a bug fix? Does > it improve interface ? > > -Petri > >
