On 10 April 2017 at 08:43, Savolainen, Petri (Nokia - FI/Espoo) <[email protected]> wrote: > > >> -----Original Message----- >> From: Ola Liljedahl [mailto:[email protected]] >> Sent: Saturday, April 08, 2017 12:13 AM >> To: Petri Savolainen <[email protected]> >> Cc: [email protected] >> Subject: Re: [lng-odp] [PATCH 1/3] test: l2fwd: add group option >> >> On 6 April 2017 at 13:59, Petri Savolainen <[email protected]> >> wrote: >> > >> > User may give number of scheduling groups to test >> > scheduler performance with other that the default (all >> > threads) group. Both pktios and threads are allocated >> >> Isn't all *workers* a better default scheduler group? In this and in >> other examples and benchmarks. > > The new thing in this patch is the -g option which enables testing of newly > created (other than default) groups. The default is not changed. In practice > "all" vs. "workers" do not matter much in our current test apps, since ctrl > threads do not call schedule(). It makes a difference to the scalable scheduler since it creates a scheduler queue per thread (as specified when the scheduler group is created). Creating more scheduler queues than threads that actually call schedule() is suboptimal.
Therefor it would be better if the (performance) tests use the "workers" scheduler group. > > I'm thinking that those automatic groups should be configurable, so that e.g. > "all" and "ctrl" maybe disabled if not used. How is is useful to disable these groups? > Those configs would go to new scheduler global config params (with other > things). Anyway, not a topic of this patch set. > > -Petri
