> -----Original Message----- > From: Dmitry Eremin-Solenikov [mailto:[email protected]] > Sent: Thursday, April 27, 2017 12:47 PM > To: Petri Savolainen <[email protected]>; lng- > [email protected] > Subject: Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: crypto: enforce > deprecated API status > > On 30.03.2017 16:58, Petri Savolainen wrote: > > diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux- > generic/odp_crypto.c > > index 2ba504b..228e598 100644 > > --- a/platform/linux-generic/odp_crypto.c > > +++ b/platform/linux-generic/odp_crypto.c > > @@ -644,12 +644,13 @@ int odp_crypto_capability(odp_crypto_capability_t > *capa) > > capa->auths.bit.sha512_hmac = 0; > > capa->auths.bit.aes_gcm = 1; > > > > - /* Deprecated */ > > +#if ODP_DEPRECATED_API > > capa->ciphers.bit.aes128_cbc = 1; > > capa->ciphers.bit.aes128_gcm = 1; > > capa->auths.bit.md5_96 = 1; > > capa->auths.bit.sha256_128 = 1; > > capa->auths.bit.aes128_gcm = 1; > > +#endif > > I thought that we can write this instead as > > capa->ciphers.bit.ODP_DEPRECATED(aes128_cbc) = 1; > capa->ciphers.bit.ODP_DEPRECATED(aes128_gcm) = 1; > capa->auths.bit.ODP_DEPRECATED(md5_96) = 1; > capa->auths.bit.ODP_DEPRECATED(sha256_128) = 1; > capa->auths.bit.ODP_DEPRECATED(aes128_gcm) = 1; > > > (same applies to other places inside odp_crypto.c). > > However we can change this later if we see point in it (or maybe a > suggestion from distro guys). I'd propose to merge this series as is. > So, for the whole patchset: > > Reviewed-by: Dmitry Eremin-Solenikov <[email protected]>
Yes, it's an implementation / coding style / packaging / etc choice whether "#if ODP_DEPRECATED_API" or "bit.ODP_DEPRECATED(foo) = 1" is used - both are possible after this set. Thanks, for the review. -Petri
