Support recently added auth_digest_length and aad parameters.
This depends on #23 (included as first two patches) and should be rebased after 
#23 gets merged into main and further into api-next.

----------------github------------------------
/** Email created from pull request 24 (lumag:crypto-dal)
 ** https://github.com/Linaro/odp/pull/24
 ** Patch: https://github.com/Linaro/odp/pull/24.patch
 ** Base sha: 540490ddf3a1b3da4b80ed15fc874ccdfc49b60c
 ** Merge commit sha: d097dfa56ce6abf579ef39d07f3ac39d6badbc92
 **/
----------------/github------------------------

----------------checkpatch.pl------------------------
total: 0 errors, 0 warnings, 0 checks, 72 lines checked


to_send-p-000.patch has no obvious style problems and is ready for submission.
CHECK: Avoid CamelCase: <EVP_DecryptFinal_ex>
#31: FILE: platform/linux-generic/odp_crypto.c:387:
+       if (EVP_DecryptFinal_ex(ctx, cipherdata + cipher_len, &plain_len) <= 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked


to_send-p-001.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: line over 80 characters
#38: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:624:
+                                       auth_key.length, 
aes128_gcm_reference_tag_length[i]))

WARNING: line over 80 characters
#56: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:668:
+                                       auth_key.length, 
aes128_gcm_reference_tag_length[i]))

WARNING: line over 80 characters
#74: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:718:
+                                       auth_key.length, 
aes128_gcm_reference_tag_length[i]))

WARNING: line over 80 characters
#83: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:732:
+                        aes128_gcm_reference_length[i] + 
aes128_gcm_reference_tag_length[i],

WARNING: line over 80 characters
#98: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:750:
+                        aes128_gcm_reference_length[i] + 
aes128_gcm_reference_tag_length[i],

WARNING: line over 80 characters
#112: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:783:
+                                       auth_key.length, 
aes128_gcm_reference_tag_length[i]))

WARNING: line over 80 characters
#121: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:797:
+                        aes128_gcm_reference_length[i] + 
aes128_gcm_reference_tag_length[i],

WARNING: line over 80 characters
#136: FILE: test/common_plat/validation/api/crypto/odp_crypto_test_inp.c:815:
+                        aes128_gcm_reference_length[i] + 
aes128_gcm_reference_tag_length[i],

total: 0 errors, 8 warnings, 0 checks, 233 lines checked


to_send-p-002.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 0 checks, 169 lines checked


to_send-p-003.patch has no obvious style problems and is ready for submission.
WARNING: Possible switch case/default not preceeded by break or fallthrough 
comment
#51: FILE: platform/linux-generic/odp_crypto.c:751:
+       case ODP_AUTH_ALG_MD5_HMAC:

WARNING: Possible switch case/default not preceeded by break or fallthrough 
comment
#60: FILE: platform/linux-generic/odp_crypto.c:758:
+       case ODP_AUTH_ALG_SHA256_HMAC:

total: 0 errors, 2 warnings, 0 checks, 40 lines checked


to_send-p-004.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 0 checks, 14 lines checked


to_send-p-005.patch has no obvious style problems and is ready for submission.
WARNING: line over 80 characters
#74: FILE: platform/linux-generic/odp_crypto.c:308:
+       EVP_CIPHER_CTX_ctrl(ctx, EVP_CTRL_GCM_GET_TAG, 
session->p.auth_digest_len, tag);

WARNING: line over 80 characters
#109: FILE: platform/linux-generic/odp_crypto.c:347:
+       EVP_CIPHER_CTX_ctrl(ctx, EVP_CTRL_GCM_SET_TAG, 
session->p.auth_digest_len, tag);

total: 0 errors, 2 warnings, 0 checks, 118 lines checked


to_send-p-006.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
----------------/checkpatch.pl------------------------

Reply via email to