In general I think that this patch is ok. It will be good to fix
following warning aslo:
WARNING: Missing a blank line after declarations
#39: FILE: platform/linux-generic/include/odp_crypto_internal.h:66:
+ uint32_t bytes;
+ const EVP_MD *evp_md;
total: 0 errors, 1 warnings, 0 checks, 208 lines checked
NOTE: Ignored message types: BIT_MACRO COMPARISON_TO_NULL
DEPRECATED_VARIABLE NEW_TYPEDEFS SPLIT_STRING SSCANF_TO_KSTRTO
0004-linux-generic-crypto-unify-auth-code.patch has style problems,
please review.
typedef
odp_crypto_alg_err_t (*crypto_func_t)(odp_crypto_op_param_t *param,
odp_crypto_generic_session_t
*session);
struct {
uint8_t key[EVP_MAX_KEY_LENGTH];
uint32_t key_length;
uint32_t bytes;
const EVP_MD *evp_md;
crypto_func_t func;
} auth;
On 05/04/2017 10:33 PM, Bill Fischofer wrote:
Update checkpatch.pl to avoid issuing warnings for use of externs,
volatile, or camelCase.
Signed-off-by: Bill Fischofer <[email protected]>
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 16316b92..1c27ac60 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4273,7 +4273,7 @@ sub process {
$camelcase_file_seeded
= 1;
}
}
- if (!defined $camelcase{$word}) {
+ if (!defined $camelcase{$word} && 0) {
$camelcase{$word} = 1;
CHK("CAMELCASE",
"Avoid CamelCase:
<$word>\n" . $herecurr);
@@ -4620,7 +4620,7 @@ sub process {
# no volatiles please
my $asm_volatile =
qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
- if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
+ if ($line =~ /\bvolatile\b/ && 0 && $line !~ /$asm_volatile/) {
WARN("VOLATILE",
"Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt\n" . $herecurr);
}
@@ -5134,7 +5134,7 @@ sub process {
if (defined $cond) {
substr($s, 0, length($cond), '');
}
- if ($s =~ /^\s*;/ &&
+ if ($s =~ /^\s*;/ && 0 &&
$function_name ne 'uninitialized_var')
{
WARN("AVOID_EXTERNS",
