Yeah, this is definitely a bug. A minimal fix would be to use
sched_fn->order_lock()/sched_fn->order_unlock() in pktout_enqueue().

-Matias

> On 17 May 2017, at 15:26, Bill Fischofer <[email protected]> wrote:
> 
> Please open a bug for this. That seems to have been an oversight as
> pktout enqueues should preserve order the same as as any other
> destination queue.
> 
> On Wed, May 17, 2017 at 4:57 AM, Peltonen, Janne (Nokia - FI/Espoo)
> <[email protected]> wrote:
>> Hi,
>> 
>> It seems that the packet enqueue order to pktout queues does
>> not necessarily match the dequeue order of an ordered source
>> queue.
>> 
>> Enqueue to a normal queue ensures the right order by interacting
>> with the scheduler in enq_multi() but the pktout specific enqueue
>> implementation pktout_enqueue() does not.
>> 
>> This changed in the following commits. Apparently something was
>> missing from the later one.
>> 
>> a267605 linux-gen: sched: new ordered queue implementation
>> 0d6d092 linux-gen: sched: remove old ordered queue implementation
>> 
>>        Janne
>> 
>> 

Reply via email to