----------------github------------------------
/** Email created from pull request 43 (nagarahalli:api-next-mod-queue1)
** https://github.com/Linaro/odp/pull/43
** Patch: https://github.com/Linaro/odp/pull/43.patch
** Base sha: 552817483e9d4b6a84d49960920f1de50029f111
** Merge commit sha: 45b775366fd2c3c85b8e1a4c3e661cc26deb5a71
**/
----------------/github------------------------
----------------checkpatch.pl------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#7:
Queue APIs and functions towards the internal components are converted into
function pointers and function pointer tables
WARNING: line over 80 characters
#43: FILE: platform/linux-generic/include/odp_queue_internal.h:91:
+int _queue_enq_multi(queue_entry_t *queue, odp_buffer_hdr_t *buf_hdr[], int
num);
WARNING: line over 80 characters
#44: FILE: platform/linux-generic/include/odp_queue_internal.h:92:
+int _queue_deq_multi(queue_entry_t *queue, odp_buffer_hdr_t *buf_hdr[], int
num);
ERROR: "foo* bar" should be "foo *bar"
#57: FILE: platform/linux-generic/include/odp_schedule_if.h:19:
+typedef void* queue_t;
CHECK: Alignment should match open parenthesis
#67: FILE: platform/linux-generic/include/odp_schedule_if.h:29:
+ int (*queue_context_set)(odp_queue_t queue, void *context,
+ uint32_t len);
CHECK: Alignment should match open parenthesis
#74: FILE: platform/linux-generic/include/odp_schedule_if.h:36:
+ int (*queue_deq_multi)(odp_queue_t queue, odp_event_t events[],
+ int num);
WARNING: line over 80 characters
#278: FILE: platform/linux-generic/odp_queue.c:229:
+static odp_queue_t queue_create(const char *name, const odp_queue_param_t
*param)
CHECK: Alignment should match open parenthesis
#297: FILE: platform/linux-generic/odp_queue.c:347:
+static int queue_context_set(odp_queue_t handle, void *context,
uint32_t len ODP_UNUSED)
WARNING: externs should be avoided in .c files
#463: FILE: platform/linux-generic/odp_schedule_if.c:9:
+extern const queue_api_t queue_default_api;
WARNING: externs should be avoided in .c files
#464: FILE: platform/linux-generic/odp_schedule_if.c:10:
+extern const queue_fn_t queue_default_fn;
total: 1 errors, 6 warnings, 3 checks, 502 lines checked
to_send-p-000.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#7:
Pkt I/O and TM access queue internal structure members. Introduced functions in
the function pointer table to access these members.
ERROR: "foo* bar" should be "foo *bar"
#56: FILE: platform/linux-generic/include/odp_schedule_if.h:46:
+typedef void* queue_t;
CHECK: Alignment should match open parenthesis
#229: FILE: platform/linux-generic/odp_queue.c:812:
+static void queue_set_deq_multi_func(queue_entry_t *queue,
+ deq_multi_func_t func)
total: 1 errors, 1 warnings, 1 checks, 219 lines checked
to_send-p-001.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 0 checks, 1006 lines checked
to_send-p-002.patch has no obvious style problems and is ready for submission.
----------------/checkpatch.pl------------------------
