> > to_send-p-013.patch has no obvious style problems and is ready for > submission. > WARNING: Missing a blank line after declarations > #45: FILE: platform/linux-generic/include/odp_crypto_internal.h:44: > + uint8_t key_data[EVP_MAX_KEY_LENGTH]; > + const EVP_CIPHER *evp_cipher; > > total: 0 errors, 1 warnings, 0 checks, 257 lines checked > >
> ERROR: Macros with multiple statements should be enclosed in a do - while > loop > #27: FILE: platform/linux-generic/odp_crypto.c:198: > +#define IN_CONSUME(len) \ > + in_pos += (len); \ > + in_len -= (len); \ > + insegaddr += (len); \ > + inseglen -= (len); > > WARNING: macros should not use a trailing semicolon > #27: FILE: platform/linux-generic/odp_crypto.c:198: > +#define IN_CONSUME(len) \ > + in_pos += (len); \ > + in_len -= (len); \ > + insegaddr += (len); \ > + inseglen -= (len); > > WARNING: line over 80 characters > #47: FILE: platform/linux-generic/odp_crypto.c:218: > + uint8_t *insegaddr = odp_packet_offset(pkt, in_pos, > &seglen, NULL); > > WARNING: line over 80 characters > #53: FILE: platform/linux-generic/odp_crypto.c:224: > + EVP_EncryptUpdate(ctx, insegaddr, > &cipher_len, insegaddr, part); > > WARNING: Missing a blank line after declarations > #53: FILE: platform/linux-generic/odp_crypto.c:224: > + unsigned part = inseglen - block_len; > + EVP_EncryptUpdate(ctx, insegaddr, > &cipher_len, insegaddr, part); > > WARNING: line over 80 characters > #61: FILE: platform/linux-generic/odp_crypto.c:232: > + EVP_EncryptUpdate(ctx, block, &cipher_len, > insegaddr, part); > > WARNING: Missing a blank line after declarations > #61: FILE: platform/linux-generic/odp_crypto.c:232: > + unsigned part = inseglen; > + EVP_EncryptUpdate(ctx, block, &cipher_len, > insegaddr, part); > > WARNING: line over 80 characters > #63: FILE: platform/linux-generic/odp_crypto.c:234: > + odp_packet_copy_from_mem(pkt, out_pos, > cipher_len, block); > > WARNING: line over 80 characters > #88: FILE: platform/linux-generic/odp_crypto.c:259: > + uint8_t *insegaddr = odp_packet_offset(pkt, in_pos, > &seglen, NULL); > > WARNING: line over 80 characters > #94: FILE: platform/linux-generic/odp_crypto.c:265: > + EVP_DecryptUpdate(ctx, insegaddr, > &cipher_len, insegaddr, part); > > WARNING: Missing a blank line after declarations > #94: FILE: platform/linux-generic/odp_crypto.c:265: > + unsigned part = inseglen - block_len; > + EVP_DecryptUpdate(ctx, insegaddr, > &cipher_len, insegaddr, part); > > WARNING: line over 80 characters > #102: FILE: platform/linux-generic/odp_crypto.c:273: > + EVP_DecryptUpdate(ctx, block, &cipher_len, > insegaddr, part); > > WARNING: Missing a blank line after declarations > #102: FILE: platform/linux-generic/odp_crypto.c:273: > + unsigned part = inseglen; > + EVP_DecryptUpdate(ctx, block, &cipher_len, > insegaddr, part); > > WARNING: line over 80 characters > #104: FILE: platform/linux-generic/odp_crypto.c:275: > + odp_packet_copy_from_mem(pkt, out_pos, > cipher_len, block); > > CHECK: Alignment should match open parenthesis > #237: FILE: platform/linux-generic/odp_crypto.c:411: > + odp_packet_copy_from_mem(param->out_pkt, param- > >hash_result_offset, > + session->p.auth_digest_len, block); > > ERROR: spaces required around that ':' (ctx:VxE) > #299: FILE: platform/linux-generic/odp_crypto.c:461: > + return ret <= 0 ? ODP_CRYPTO_ALG_ERR_ICV_CHECK: > ^ > > total: 2 errors, 13 warnings, 1 checks, 269 lines checked > > > to_send-p-017.patch has style problems, please review. > All these checkpatch warnings seem valid and should be corrected. Basically everything else but the CamelCase ones which is caused by OpenSSL API. -Petri
