> -----Original Message----- > From: lng-odp [mailto:[email protected]] On Behalf Of Brian > Brooks > Sent: Thursday, June 08, 2017 11:17 PM > To: [email protected] > Subject: [lng-odp] [API-NEXT v3 2/2] timer: allow timer processing to run > on worker cores > > Run timer pool processing on worker cores if the application hints > that the scheduler will be used. This reduces the latency and jitter > of the point at which timer pool processing begins. See [1] for details. > > [1] https://docs.google.com/document/d/1sY7rOxqCNu-bMqjBiT5_keAIohrX1ZW- > eL0oGLAQ4OM/edit?usp=sharing > > Signed-off-by: Brian Brooks <[email protected]> > Reviewed-by: Ola Liljedahl <[email protected]> > Reviewed-by: Honnappa Nagarahalli <[email protected]> > --- > > v3: > - Add rate limiting by scheduling rounds > > v2: > - Reword 'worker_timers' to 'use_scheduler' > - Use ODP Time instead of ticks > > > include/odp/api/spec/init.h | 5 ++ > platform/linux-generic/include/odp_internal.h | 1 + > .../linux-generic/include/odp_timer_internal.h | 11 +++ > platform/linux-generic/odp_init.c | 8 +- > platform/linux-generic/odp_schedule.c | 4 +- > platform/linux-generic/odp_schedule_iquery.c | 3 + > platform/linux-generic/odp_schedule_sp.c | 4 + > platform/linux-generic/odp_timer.c | 98 > ++++++++++++++++++++-- > 8 files changed, 122 insertions(+), 12 deletions(-) > > diff --git a/include/odp/api/spec/init.h b/include/odp/api/spec/init.h > index 154cdf8f..44950893 100644 > --- a/include/odp/api/spec/init.h > +++ b/include/odp/api/spec/init.h > @@ -153,6 +153,11 @@ typedef struct odp_init_t { > odp_log_func_t log_fn; > /** Replacement for the default abort fn */ > odp_abort_func_t abort_fn; > + /** Whether the application will ever call odp_schedule() or > not. > + > + Default: true > + */ > + odp_bool_t use_scheduler; > } odp_init_t;
This will not be merged, not even temporarily. We should avoid unnecessary (API) changes back and forth. Instead of this, we'll add odp_feature_t bit field as discussed before. -Petri
