uh, this needs to be tested before submitting. If autoconf-archive is not installed there is error:
./configure: line 22658: syntax error near unexpected token `-Wimplicit-fallthrough=0,' ./configure: line 22658: `AX_CHECK_COMPILE_FLAG(-Wimplicit-fallthrough=0,' I think that needs to be fixed. Maybe check for all required packages when run configure. Bug can not be closed. Maxim. On 06/08/17 23:45, Bill Fischofer wrote: > It's OK to propagate my review to small revisions in response to later > comments. Dmitry can add his review for the changes he requested. > > Reviewed-by: Bill Fischofer <[email protected]> > > On Thu, Jun 8, 2017 at 3:42 PM, Brian Brooks <[email protected]> wrote: >> The GCC 7 series introduces changes that expose ODP compilation >> issues. These include case statement fall through warnings, and >> stricter checks on potential string overflows and other semantic >> analysis. >> >> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 >> >> >> v5: >> - Make -latomic only a libodp.a/so dependency (Dmitry) >> >> v4: >> - Add -Werror to AX_CHECK_COMPILE_FLAG for Clang (Bill) >> >> v3: >> - Split into multiple patches files (Maxim) >> - Disable warnings in favor of patching right now (Dmitry) >> - Improve libatomic detection in autoconf (Dmitry) >> - Add autoconf-arch to DEPENDENCIES file >> >> v2: >> - Add Bug id to commit message (Bill) >> >> >> Brian Brooks (2): >> build: GCC 7 fixes >> pktio: GCC 7 fixes >> >> DEPENDENCIES | 5 +-- >> configure.ac | 13 ++++++++ >> pkgconfig/libodp-linux.pc.in | 2 +- >> platform/linux-generic/Makefile.am | 2 ++ >> platform/linux-generic/m4/configure.m4 | 45 >> +++++++++++++++++++++++++++ >> test/common_plat/validation/api/pktio/pktio.c | 4 ++- >> 6 files changed, 67 insertions(+), 4 deletions(-) >> >> -- >> 2.13.0 >>
