On 14.06.2017 12:53, Dmitry Eremin-Solenikov wrote:
> On 09.06.2017 15:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>>>> @@ -934,41 +926,70 @@ typedef struct odp_ipsec_op_status_t {
>>>> } odp_ipsec_op_status_t;
>>>>
>>>> /**
>>>> - * IPSEC operation input parameters
>>>> + * IPSEC outbound operation options
>>>> + *
>>>> + * These may be used to override some SA level options
>>>> */
>>>> -typedef struct odp_ipsec_op_param_t {
>>>> - /** Number of packets to be processed */
>>>> - int num_pkt;
>>>> +typedef struct odp_ipsec_out_opt_t {
>>>> + /** Fragmentation mode */
>>>> + odp_ipsec_frag_mode_t mode;
>>>> +
>>>> +} odp_ipsec_out_opt_t;
>>>
>>> Maybe we can just inline this into out_param_t ?
>>> With this in/out split, it should be quite straightforward change from
>>> the API point of view.
>>
>>
>> The thing is that it's a pointer to an odp_ipsec_out_opt_t array, so
>> application needs the type above. Otherwise, we'd need to define maximum of
>> opts in the API, which would be the same as maximum number of packets. API
>> doesn't need to limit the burst size.
>
> I would suggest to move odp_ipsec_out_opt_t contents completely into the
> odp_ipsec_out_param_t. One would have to fill it in every param, however
> this might result in simpler code. This is just an idea for you to
> consider, not a requirement of course.
I got what you meant. Please ignore this comment.
--
With best wishes
Dmitry
