Some queries: - Now since IPSEC, and simple IPSEC packets are delivered through same ODP_EVENT_TYPE_PACKET, how does application knows whether L2_HEADER was valid?? Does application always have to check on subtype? - Also, do we need separate odp_ipsec_packet_to_event APIs(and vice versa) now? If yes, it will defeat the purpose of subtypes. - Does error in IPSEC operation affects, packet error flags?? - Since IN/OUT params for IPSEC operations are different, does NUM_SA=0 is a valid input for out_sa_params? - ODP_EVENT_IPSEC_STATUS events are delivered on SA queues or default queue? - Will per packet checksum override work in conjunction with IPSEC_SA settings as well?
Regards Nikhil -----Original Message----- From: lng-odp [mailto:[email protected]] On Behalf Of Bill Fischofer Sent: Saturday, June 17, 2017 3:46 AM To: Petri Savolainen <[email protected]> Cc: lng-odp-forward <[email protected]> Subject: Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event This should still be reviewed by Bala and Nikhil with respect to their HW, but these changes resolve all of the concerns I had with the original version. For his series: Reviewed-by: Bill Fischofer <[email protected]> On Fri, Jun 16, 2017 at 5:49 AM, Petri Savolainen <[email protected]> wrote: > Applies on top of: "[API-NEXT PATCH v2 0/2] IPsec API update" > > Input and output of IPSEC operations are packets. Parameter and result > structures are cleaner when packet arrays are direct parameters to > functions. Also API is more flexible for application or API pipelining > when output is packets with additional metadata. Application or API > pipeline stages which do not care about IPSEC results may work on > basic packet metadata. > > v3: > * typo corrected (Bill) > > v2: > * Introduce event subtype > * event type "packet" is the same for all packets > * event subtype "packet_ipsec" indicates that a packet contain IPSEC > results > * Added output packet format description, which was accidentally left out > from previous version (moved text from deleted result type to > odp_ipsec_in() / odp_ipsec_out() documentation) > > > Petri Savolainen (3): > api: event: add subtype to expand event type > api: ipsec: change IPSEC result to packet > api: ipsec: disable event is the last event > > include/odp/api/spec/event.h | 80 +++- > include/odp/api/spec/ipsec.h | 417 > ++++++++++++--------- > include/odp/arch/default/api/abi/event.h | 9 +- > .../include/odp/api/plat/event_types.h | 8 +- > platform/linux-generic/odp_ipsec.c | 67 +++- > 5 files changed, 372 insertions(+), 209 deletions(-) > > -- > 2.13.0 >
