For this patch: Reviewed-by: Bill Fischofer <[email protected]>
On Mon, Jun 19, 2017 at 8:12 AM, Maxim Uvarov <[email protected]> wrote: > top_builddir alphabetical before top_srcdir. But here I'm ok with current > change. > > Bill, review + ? > > Maxim. > > On 19 June 2017 at 14:58, Savolainen, Petri (Nokia - FI/Espoo) > <[email protected]> wrote: >> >> >> >> > -----Original Message----- >> > From: Bill Fischofer [mailto:[email protected]] >> > Sent: Monday, June 19, 2017 1:31 PM >> > To: Petri Savolainen <[email protected]> >> > Cc: lng-odp-forward <[email protected]> >> > Subject: Re: [lng-odp] [PATCH] linux-gen: makefile: fix out of tree >> > build >> > >> > On Mon, Jun 19, 2017 at 3:25 AM, Petri Savolainen >> > <[email protected]> wrote: >> > > Generated files need $(top_builddir) instead of $(top_srcdir) >> > > >> > > Fixes bug https://bugs.linaro.org/show_bug.cgi?id=3052 >> > > >> > > Signed-off-by: Petri Savolainen <[email protected]> >> > > --- >> > > platform/Makefile.inc | 6 +++--- >> > > 1 file changed, 3 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/platform/Makefile.inc b/platform/Makefile.inc >> > > index 9844a58a..1903d92d 100644 >> > > --- a/platform/Makefile.inc >> > > +++ b/platform/Makefile.inc >> > > @@ -29,7 +29,6 @@ odpapispecinclude_HEADERS = \ >> > > $(top_srcdir)/include/odp/api/spec/cpumask.h \ >> > > $(top_srcdir)/include/odp/api/spec/crypto.h \ >> > > $(top_srcdir)/include/odp/api/spec/debug.h \ >> > > - $(top_srcdir)/include/odp/api/spec/deprecated.h \ >> > > $(top_srcdir)/include/odp/api/spec/errno.h \ >> > > $(top_srcdir)/include/odp/api/spec/event.h \ >> > > $(top_srcdir)/include/odp/api/spec/hash.h \ >> > > @@ -58,8 +57,9 @@ odpapispecinclude_HEADERS = \ >> > > $(top_srcdir)/include/odp/api/spec/ticketlock.h \ >> > > $(top_srcdir)/include/odp/api/spec/time.h \ >> > > $(top_srcdir)/include/odp/api/spec/timer.h \ >> > > - $(top_builddir)/include/odp/api/spec/version.h \ >> > > - $(top_srcdir)/include/odp/api/spec/traffic_mngr.h >> > > + $(top_srcdir)/include/odp/api/spec/traffic_mngr.h \ >> > > + $(top_builddir)/include/odp/api/spec/deprecated.h \ >> > > + $(top_builddir)/include/odp/api/spec/version.h >> > >> > Shouldn't this list be maintained in alphabetical order? >> >> It's ordered first by path, then by file name in alphabetical order. First >> all $(top_srcdir), then all $(top_builddir). The bug was in not using >> $(top_builddir). This order highlights that the path matters. >> >> -Petri >> >> >
