No, that patch is not correct. Take a look at top level Makefile.am:
AM_DISTCHECK_CONFIGURE_FLAGS = --enable-test-cpp \
                               --enable-test-perf \
                               --enable-test-vald \
                               --with-testdir

parameters to configure are skipped and only that one are used.

Maxim.


On 06/19/17 11:00, Github ODP bot wrote:
> From: Yi He <yi...@linaro.org>
> 
> enable samples and tests when make distcheck to
> confirm samples and test programs installation and
> distribution builds.
> 
> Signed-off-by: Yi He <yi...@linaro.org>
> ---
> /** Email created from pull request 35 (heyi-linaro:install-check)
>  ** https://github.com/Linaro/odp/pull/35
>  ** Patch: https://github.com/Linaro/odp/pull/35.patch
>  ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14
>  ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb
>  **/
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 50b3b9c2..8407906e 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -136,7 +136,7 @@ jobs:
>                    compiler: gcc
>                    script:
>                            - ./bootstrap
> -                          - ./configure
> +                          - ./configure --prefix=$HOME/odp-install 
> --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf 
> --enable-test-perf-proc --enable-test-example 
> --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap
>                            - sudo 
> LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck
>                  - stage: test
>                    env: TEST=doxygen
> 

Reply via email to