> -----Original Message----- > From: lng-odp [mailto:[email protected]] On Behalf Of > Honnappa Nagarahalli > Sent: Thursday, June 22, 2017 12:20 AM > To: Maxim Uvarov <[email protected]> > Cc: lng-odp-forward <[email protected]> > Subject: Re: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: queue: > modular queue interface > > Agree, will rebase and update once we have the scalable queues merged. > > On 21 June 2017 at 14:53, Maxim Uvarov <[email protected]> wrote: > > On 06/19/17 08:00, Github ODP bot wrote: > >> log | 1269 > ++++++++++++++++++++ > > > > log has not be a part of patch. > > > > Maxim.
To be sure, I repeat my opinion about this RFC again. The internal queue pointer (or table index - format does not matter) is needed to avoid doing the same (API handle <-> qentry) conversion multiple times. We are inside implementation, and it improves performance when the number of conversions per packet is minimized. That's why there were direct qentry access outside of queue.c in the first place. I'll look into the internal queue interface definition to optimize it. This current version is just a dummy, copy-paste replacement of qentry->xxx with fn_queue->xxx(). Which is OK for the first stage, but certainly not optimal/final solution. -Petri
