On 23.06.2017 01:05, Brian Brooks wrote: > Explicitly add all arch/<arch>/* files to respective _SOURCES > variables instead of using @ARCH_DIR@ substitution. > > This patch fixes the broken build for ARM, PPC, and MIPS > introduced by [1] and the similar issue reported while > testing [2]. > > From the Autoconf manual [3]: > > You can't put a configure substitution (e.g., '@FOO@' or > '$(FOO)' where FOO is defined via AC_SUBST) into a _SOURCES > variable. The reason for this is a bit hard to explain, but > suffice to say that it simply won't work. > > Here be dragons.. > > [1] https://lists.linaro.org/pipermail/lng-odp/2017-April/030324.html > [2] https://lists.linaro.org/pipermail/lng-odp/2017-June/031598.html > [3] > https://www.gnu.org/software/automake/manual/html_node/Conditional-Sources.html > > Signed-off-by: Brian Brooks <[email protected]> > Reviewed-by: Kevin Wang <[email protected]> > Reviewed-by: Yi He <[email protected]> > Reviewed-by: Honnappa Nagarahalli <[email protected]>
Reviewed-by: Dmitry Eremin-Solenikov -- With best wishes Dmitry
