Branch: refs/heads/master
Home: https://github.com/Linaro/odp
Commit: e7e92031e08fe525e421ab30223b7398881ed42e
https://github.com/Linaro/odp/commit/e7e92031e08fe525e421ab30223b7398881ed42e
Author: Brian Brooks <[email protected]>
Date: 2017-06-23 (Fri, 23 Jun 2017)
Changed paths:
M configure.ac
M platform/linux-generic/Makefile.am
Log Message:
-----------
build: fix conditional compilation of sources
Explicitly add all arch/<arch>/* files to respective _SOURCES
variables instead of using @ARCH_DIR@ substitution.
This patch fixes the broken build for ARM, PPC, and MIPS
introduced by [1] and the similar issue reported while
testing [2].
>From the Autoconf manual [3]:
You can't put a configure substitution (e.g., '@FOO@' or
'$(FOO)' where FOO is defined via AC_SUBST) into a _SOURCES
variable. The reason for this is a bit hard to explain, but
suffice to say that it simply won't work.
Here be dragons..
[1] https://lists.linaro.org/pipermail/lng-odp/2017-April/030324.html
[2] https://lists.linaro.org/pipermail/lng-odp/2017-June/031598.html
[3]
https://www.gnu.org/software/automake/manual/html_node/Conditional-Sources.html
Signed-off-by: Brian Brooks <[email protected]>
Reviewed-by: Kevin Wang <[email protected]>
Reviewed-by: Yi He <[email protected]>
Reviewed-by: Honnappa Nagarahalli <[email protected]>
Reviewed-by: Dmitry Eremin-Solenikov <[email protected]>
Signed-off-by: Maxim Uvarov <[email protected]>
