On 27 July 2017 at 13:13, Liron Himi <lir...@marvell.com> wrote: > Hi Bala, > > > > By pktin queues you are referring to ‘num _*queues’ and ‘queue*_param’ as > part of the odp_pktin_queu_param_t? > > > > Odp 1.15 API have the following: > > /** Number of input queues to be created > > * > > * When classifier is enabled in odp_pktin_queue_config() > this > > * value is ignored, otherwise at least one queue is > required. > > * More than one input queues require flow hashing > configured. > > * The maximum value is defined by pktio capability > 'max_input_queues'. > > * Queue type is defined by the input mode. The default > value is 1. */ > > unsigned num_queues; > > > > So, I understand that when classifier is enable there are no pktin queues, > right? > > > > When application want to have classification support and connect it to > PKTIO it MUST set ‘classifier_enable’ in PKTIO? >
Yes. I stand corrected with the documentation as is setting "classifier_enable" is a mandatory field. I will update the test cases accordingly. Regards, Bala > > > Liron > > > > *From:* Bala Manoharan [mailto:bala.manoha...@linaro.org] > *Sent:* Thursday, July 27, 2017 04:48 > *To:* Liron Himi <lir...@marvell.com> > *Cc:* lng-odp@lists.linaro.org > *Subject:* [EXT] Re: [lng-odp] PKTIO and classification > > > > External Email > ------------------------------ > > > > On 26 July 2017 at 01:24, Liron Himi <lir...@marvell.com> wrote: > > Hi, > > I have a few questions/clarifications regarding classification in PKTIO: > > 1. As part of the 'odp_pktin_queue_param_t' application should set > 'classifier_enable' to '1' if classification support is wanted. Is that > correct? > > 2. If #1 is correct, then why I can't see in the > classification-pktio validation tests that this parameter is set? Is I > missing something? > > Our PKTIO implementation behave differently if 'classifier_enable' is set, > so it is very important to understand if there is a gap in our > understanding. > > > > odp_pktin_queue_param_t configuration is required only when pktin queues > are configured to an interface. "classifier_enable" field is required only > when both classification and pktin queue and classification configuration > has been given simultaneously in the system. > > > > I will update the documentation to clarify this discrepancy. > > > > Regards, > Bala > > > > > Thanks in advance, > Liron > > >
