This PR replaces #28 by providing new IPsec implementation based on latest API additions.
----------------github------------------------ /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base sha: c16f1363303cd5fc11324acbc4dfebe0a9680a41 ** Merge commit sha: 85fc2735116c657c5c5d5f78e419e0323a473a09 **/ ----------------/github------------------------ ----------------checkpatch.pl------------------------ WARNING: line over 80 characters #38: FILE: platform/linux-generic/pktio/loop.c:178: + _odp_buffer_event_subtype_set(buf_from_buf_hdr(hdr_tbl[i]), total: 0 errors, 1 warnings, 0 checks, 26 lines checked to_send-p-000.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 0 checks, 19 lines checked to_send-p-001.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 164 lines checked to_send-p-002.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 17 lines checked to_send-p-003.patch has no obvious style problems and is ready for submission. CHECK: Avoid CamelCase: <pName> #804: FILE: test/common_plat/validation/api/ipsec/ipsec.c:717: + for (i = 0; suite[i].pName; i++) { CHECK: Please don't use multiple blank lines #1104: FILE: test/common_plat/validation/api/ipsec/ipsec_async.c:32: + + CHECK: Please don't use multiple blank lines #1167: FILE: test/common_plat/validation/api/ipsec/ipsec_inline_in.c:34: + + CHECK: Please don't use multiple blank lines #1229: FILE: test/common_plat/validation/api/ipsec/ipsec_inline_out.c:34: + + CHECK: Please don't use multiple blank lines #1305: FILE: test/common_plat/validation/api/ipsec/ipsec_sync.c:30: + + CHECK: Alignment should match open parenthesis #2588: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:18: +KEY(key_a5_128, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, + 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5); CHECK: Alignment should match open parenthesis #2590: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:20: +KEY(key_5a_128, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, + 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a); CHECK: Alignment should match open parenthesis #2592: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:22: +KEY(key_a5_256, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, + 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, 0xa5, CHECK: Alignment should match open parenthesis #2596: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:26: +KEY(key_5a_256, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, + 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, 0x5a, CHECK: Alignment should match open parenthesis #2601: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:31: +KEY(key_rfc3602, 0x90, 0xd3, 0x82, 0xb4, 0x10, 0xee, 0xba, 0x7a, + 0xd9, 0x38, 0xc4, 0x6c, 0xec, 0x1a, 0x82, 0xbf); CHECK: Alignment should match open parenthesis #2603: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:33: +KEY(key_rfc3602_2, 0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef, + 0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef); CHECK: Alignment should match open parenthesis #2605: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:35: +KEY(key_mcgrew_gcm_2, 0xfe, 0xff, 0xe9, 0x92, 0x86, 0x65, 0x73, 0x1c, + 0x6d, 0x6a, 0x8f, 0x94, 0x67, 0x30, 0x83, 0x08); CHECK: Alignment should match open parenthesis #2608: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:38: +KEY(key_mcgrew_gcm_3, 0xab, 0xbc, 0xcd, 0xde, 0xf0, 0x01, 0x12, 0x23, + 0x34, 0x45, 0x56, 0x67, 0x78, 0x89, 0x9a, 0xab, CHECK: Alignment should match open parenthesis #2613: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:43: +KEY(key_mcgrew_gcm_4, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00); CHECK: Alignment should match open parenthesis #2616: FILE: test/common_plat/validation/api/ipsec/test_vectors.h:46: +KEY(key_mcgrew_gcm_12, 0x7d, 0x77, 0x3d, 0x00, 0xc1, 0x44, 0xc5, 0x25, + 0xac, 0x61, 0x9d, 0x18, 0xc8, 0x4a, 0x3f, 0x47); total: 0 errors, 0 warnings, 15 checks, 3425 lines checked to_send-p-004.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 0 checks, 335 lines checked to_send-p-005.patch has no obvious style problems and is ready for submission. ERROR: space prohibited after that '&' (ctx:WxW) #439: FILE: platform/linux-generic/odp_ipsec_sad.c:137: + if (state & IPSEC_SA_STATE_DISABLE) ^ ERROR: space prohibited after that '-' (ctx:WxW) #458: FILE: platform/linux-generic/odp_ipsec_sad.c:156: + state - 1); ^ ERROR: space prohibited after that '&' (ctx:WxW) #674: FILE: platform/linux-generic/odp_ipsec_sad.c:372: + if (state & IPSEC_SA_STATE_DISABLE) ^ total: 3 errors, 0 warnings, 0 checks, 739 lines checked to_send-p-006.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. CHECK: Please don't use multiple blank lines #36: FILE: platform/linux-generic/include/odp_ipsec_internal.h:185: + WARNING: line over 80 characters #704: FILE: platform/linux-generic/odp_ipsec.c:624: + uint32_t len = odp_random_data(iv + ipsec_sa->salt_length, total: 0 errors, 1 warnings, 1 checks, 1283 lines checked to_send-p-007.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ----------------/checkpatch.pl------------------------
