This is an API change, that I did oppose on June 16th. Why it's now merged?

What is the requirement ("All threads that have joined the group must leave 
before destroying the group") ? A thread may be in a group due to automatic 
group (no create/join called), being part of thread mask in a create call or 
being part of thread mask in a join call. Also, thread itself may not call 
create/join/leave, but another thread may do that for it.

In which cases a thread needs to be removed by explicit leave() call?  Always, 
when create() was called, only when join() was called ?

-Petri
 

> -----Original Message-----
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> GitHub
> Sent: Monday, August 07, 2017 1:59 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [Linaro/odp] 09ce94: api: schedule: add thread removal
> correction
> 
>   Branch: refs/heads/api-next
>   Home:   https://github.com/Linaro/odp
>   Commit: 09ce9406e09eacadf8f739ae8499323ad1401d36
> 
> https://github.com/Linaro/odp/commit/09ce9406e09eacadf8f739ae8499323ad1401
> d36
>   Author: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
>   Date:   2017-08-07 (Mon, 07 Aug 2017)
> 
>   Changed paths:
>     M include/odp/api/spec/schedule.h
> 
>   Log Message:
>   -----------
>   api: schedule: add thread removal correction
> 
> Clarify thread removal status from scheduler group
> before calling odp_schedule_group_destroy.
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Reviewed-by: Brian Brooks <brian.bro...@arm.com>
> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com>
> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org>
> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org>
> 

Reply via email to