On 11/01/17 21:10, Liron Himi wrote: > Hi, > > When I try to use either 'ODPH_IPPROTO_ICMPv4' in my code then checkpatch is > failing on > 'CHECK: Avoid CamelCase: <ODPH_IPPROTO_ICMPv4>'. > > Are those kind of 'check' errors can be ignored? > Maybe it will be better if you change 'ODPH_IPPROTO_ICMPv4' to > 'ODPH_IPPROTO_ICMPV4' same as 'ODPH_ETHTYPE_IPV4'. > > Thanks, > Liron >
yes, it's better to change. We might skipped this on review. Maxim.
