From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> DES-CBC (not 3DES-CBC) support is invalid (DES should use 8 bytes key, not 24 bytes), it is not covered by testsuite and DES is cracable/deprecated/etc since long ago. Stop providing single-key DES support. In case one really needs it, it can be emulated through supplying same key triple times to 3DES-CBC.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- /** Email created from pull request 289 (lumag:nodes) ** https://github.com/Linaro/odp/pull/289 ** Patch: https://github.com/Linaro/odp/pull/289.patch ** Base sha: 29c7a054f7151d33795a0d8d7df5594bf4fddb55 ** Merge commit sha: 98de673e13800b64d64bbfd36986b25895fc82a4 **/ platform/linux-generic/odp_crypto.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 40b6d74b4..d79836671 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -25,7 +25,6 @@ #include <string.h> #include <stdlib.h> -#include <openssl/des.h> #include <openssl/rand.h> #include <openssl/hmac.h> #include <openssl/evp.h> @@ -40,9 +39,6 @@ static const odp_crypto_cipher_capability_t cipher_capa_null[] = { {.key_len = 0, .iv_len = 0} }; -static const odp_crypto_cipher_capability_t cipher_capa_des[] = { -{.key_len = 24, .iv_len = 8} }; - static const odp_crypto_cipher_capability_t cipher_capa_trides_cbc[] = { {.key_len = 24, .iv_len = 8} }; @@ -582,7 +578,6 @@ int odp_crypto_capability(odp_crypto_capability_t *capa) memset(capa, 0, sizeof(odp_crypto_capability_t)); capa->ciphers.bit.null = 1; - capa->ciphers.bit.des = 1; capa->ciphers.bit.trides_cbc = 1; capa->ciphers.bit.aes_cbc = 1; capa->ciphers.bit.aes_gcm = 1; @@ -620,10 +615,6 @@ int odp_crypto_cipher_capability(odp_cipher_alg_t cipher, src = cipher_capa_null; num = sizeof(cipher_capa_null) / size; break; - case ODP_CIPHER_ALG_DES: - src = cipher_capa_des; - num = sizeof(cipher_capa_des) / size; - break; case ODP_CIPHER_ALG_3DES_CBC: src = cipher_capa_trides_cbc; num = sizeof(cipher_capa_trides_cbc) / size; @@ -737,7 +728,6 @@ odp_crypto_session_create(odp_crypto_session_param_t *param, session->cipher.func = null_crypto_routine; rc = 0; break; - case ODP_CIPHER_ALG_DES: case ODP_CIPHER_ALG_3DES_CBC: rc = process_cipher_param(session, EVP_des_ede3_cbc()); break;
