Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/crypto.h
@@ -131,6 +131,12 @@ typedef enum {
*/
ODP_AUTH_ALG_AES_GCM,
+ /** AES in Galois/Counter MAC Mode
+ *
+ * @note Must be paired with cipher ODP_CIPHER_ALG_NULL
+ */
+ ODP_AUTH_ALG_AES_GMAC,
Comment:
This should specify that GMAC authentication is done for packet payload
(instead of AAD). NIST/RFC documents use term AAD for the data. So, add here
(or somewhere in the file) a reference to e.g.
https://csrc.nist.gov/publications/detail/sp/800-38d/final, and document that
AAD there means packet payload in ODP with GMAC.
For other algos AAD is the same as NIST/RFC specs.
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> You're right. This one is a false positive on checkpatch's part.
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Checkpatch flags this line as > 80 chars. Easy to reflow, e.g., move the
>> `0x6a` to the earlier line.
https://github.com/Linaro/odp/pull/288#discussion_r149957189
updated_at 2017-11-09 13:36:42
