Josep Puigdemont(joseppc) replied on github web page:
platform/linux-generic/pktio/tap.c
line 10
@@ -92,23 +92,30 @@ static int tap_pktio_open(odp_pktio_t id ODP_UNUSED,
int fd, skfd, flags;
uint32_t mtu;
struct ifreq ifr;
- pktio_ops_tap_data_t *tap = odp_ops_data(pktio_entry, tap);
+ pktio_ops_tap_data_t *tap = NULL;
if (strncmp(devname, "tap:", 4) != 0)
return -1;
+ if (pool == ODP_POOL_INVALID)
Comment:
It probably belongs to its own patch, but now that you are at it, it could even
be moved even further up, as it is probably faster than checking for "tap:" in
the device string.
> Josep Puigdemont(joseppc) wrote:
> (_p)? There are a couple more, also in odp_ops_data_free.
>> Josep Puigdemont(joseppc) wrote:
>> Maybe we can return (void *)? This way we would not care if pktios name (or
>> define) their private structures according to the naming conventions
>> implicit in the macro.
https://github.com/Linaro/odp/pull/297#discussion_r151400312
updated_at 2017-11-16 12:33:47
