Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/odp_packet.c
line 50
@@ -1996,7 +2016,10 @@ static inline void parse_udp(packet_parser_t *prs,
if (offset)
*offset += sizeof(_odp_udphdr_t);
- *parseptr += sizeof(_odp_udphdr_t);
+ *parseptr += _ODP_UDPHDR_LEN;
+ dport = odp_be_to_cpu_16(udp->dst_port);
+ if (dport == _ODP_UDP_VXLAN_PORT)
+ parse_vxlan(prs, in_p, parseptr, offset, frame_len, seg_len);
Comment:
Need to validate that the packet (and specified UDP length) is large enough to
contain the VXLAN header and the encapsulated packet.
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Inclusion of new APIs means this PR must be against api-next, not master.
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> [RFC 7348](https://tools.ietf.org/html/rfc7348) uses VXLAN, not VxLAN. I
>> think we should use that throughout ODP as well as it avoids unnecessary
>> CamelCase.
>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>> Same comments here as for helper version of file.
>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>> Typo: reserve, not reseve? Perhaps better for these to be anonymous
>>>> bitfields if they are truly unreferenced?
https://github.com/Linaro/odp/pull/345#discussion_r157110002
updated_at 2017-12-15 02:13:15
