Juha-Matti Tilli(jmtilli) replied on github web page:
platform/linux-generic/odp_packet_io.c
line 32
@@ -1617,6 +1634,46 @@ int odp_pktin_recv_tmo(odp_pktin_queue_t queue,
odp_packet_t packets[], int num,
}
}
+static int odp_pktin_recv_mq_tmo_select(const odp_pktin_queue_t queues[],
Comment:
Will fix.
> Juha-Matti Tilli(jmtilli) wrote:
> I disagree. SLEEP_NSEC is a private #define in odp_packet_io.c so what the
> wait parameter actually means cannot be interpreted in the drivers. (Believe
> me, I tried it!) Thus, the conversion from the sleep wait parameter to
> microseconds is needed.
>> Matias Elo(matiaselo) wrote:
>> As I noted in the previous comment, I think this check isn't enough. The
>> input queues would have to be from the same pktio device for this to work.
>>> Matias Elo(matiaselo) wrote:
>>> Internal functions should not use odp_ prefix.
>>>> Matias Elo(matiaselo) wrote:
>>>> You should pass the `wait` parameter to `entry->s.ops->recv_tmo()` and not
>>>> do any conversions here.
>>>>> Matias Elo(matiaselo) wrote:
>>>>> ODP_TIME_SEC_IN_NS would work here.
https://github.com/Linaro/odp/pull/341#discussion_r157250450
updated_at 2017-12-15 17:02:26
