@JannePeltonen
This is the promised OpenSSL CTX rework, bringing significant crypto speedup

----------------github------------------------
/** Email created from pull request 342 (lumag:openssl-ctx)
 ** https://github.com/Linaro/odp/pull/342
 ** Patch: https://github.com/Linaro/odp/pull/342.patch
 ** Base sha: 49ebafae0edebbc750742d8874ad0a7588286dea
 ** Merge commit sha: a7b33af3346ca9716c2d6d2f9f7952377cedeebf
 **/
----------------/github------------------------

----------------checkpatch.pl------------------------
total: 0 errors, 0 warnings, 0 checks, 89 lines checked


to_send-p-000.patch has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 0 checks, 71 lines checked


to_send-p-001.patch has no obvious style problems and is ready for submission.
CHECK: spaces preferred around that '*' (ctx:WxV)
#88: FILE: platform/linux-generic/odp_crypto.c:158:
+       HMAC_CTX *hmac_ctx[MAX_SESSIONS];
                 ^

CHECK: spaces preferred around that '*' (ctx:WxV)
#89: FILE: platform/linux-generic/odp_crypto.c:159:
+       EVP_CIPHER_CTX *cipher_ctx[MAX_SESSIONS];
                       ^

CHECK: spaces preferred around that '*' (ctx:WxV)
#90: FILE: platform/linux-generic/odp_crypto.c:160:
+       EVP_CIPHER_CTX *mac_cipher_ctx[MAX_SESSIONS];
                       ^

CHECK: Alignment should match open parenthesis
#101: FILE: platform/linux-generic/odp_crypto.c:171:
+static inline int crypto_should_init(odp_crypto_generic_session_t *session,
+                             crypto_kind_t kind)

WARNING: line over 80 characters
#135: FILE: platform/linux-generic/odp_crypto.c:207:
+               atom_bitset_clr(cv, session->idx % ATOM_BITSET_SIZE, 
__ATOMIC_ACQ_REL);

WARNING: line over 80 characters
#136: FILE: platform/linux-generic/odp_crypto.c:208:
+               cv = global->cipher_valid[i] + (session->idx / 
ATOM_BITSET_SIZE);

WARNING: line over 80 characters
#137: FILE: platform/linux-generic/odp_crypto.c:209:
+               atom_bitset_clr(cv, session->idx % ATOM_BITSET_SIZE, 
__ATOMIC_ACQ_REL);

WARNING: line over 80 characters
#138: FILE: platform/linux-generic/odp_crypto.c:210:
+               cv = global->mac_cipher_valid[i] + (session->idx / 
ATOM_BITSET_SIZE);

WARNING: line over 80 characters
#139: FILE: platform/linux-generic/odp_crypto.c:211:
+               atom_bitset_clr(cv, session->idx % ATOM_BITSET_SIZE, 
__ATOMIC_ACQ_REL);

CHECK: Avoid CamelCase: <HMAC_Init_ex>
#189: FILE: platform/linux-generic/odp_crypto.c:264:
+               HMAC_Init_ex(ctx,

CHECK: Avoid CamelCase: <EVP_EncryptInit_ex>
#261: FILE: platform/linux-generic/odp_crypto.c:499:
+               EVP_EncryptInit_ex(ctx, session->cipher.evp_cipher, NULL,

CHECK: Avoid CamelCase: <EVP_DecryptInit_ex>
#292: FILE: platform/linux-generic/odp_crypto.c:529:
+               EVP_DecryptInit_ex(ctx, session->cipher.evp_cipher, NULL,

total: 0 errors, 5 warnings, 7 checks, 483 lines checked


to_send-p-002.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
----------------/checkpatch.pl------------------------

Reply via email to