muvarov replied on github web page: helper/m4/configure.m4 line 14 @@ -8,14 +8,13 @@ AC_ARG_ENABLE([test-helper], AM_CONDITIONAL([test_helper], [test x$test_helper = xyes ]) ########################################################################## -# Enable/disable helper-ext -# platform specific non portable extensions +# Enable/disable Linux helpers ########################################################################## -helper_linux=no +helper_linux=yes AC_ARG_ENABLE([helper-linux], - [ --enable-helper-linux build helper platform extensions (not portable)], - [if test "x$enableval" = "xyes"; then - helper_linux=yes + [ --enable-helper-linux enable Linux helpers],
Comment: if you enable it by default ./configure --help should print --disable-helper-linux disable Linux helpers. > Dmitry Eremin-Solenikov(lumag) wrote: > As you are touching this line, could you please use AS_HELP_STRING here? >> Petri Savolainen(psavol) wrote: >> corrected in v2 >>> Josep Puigdemont(joseppc) wrote: >>> Shouldn't we add a test now checking if $enableval is "no" here? https://github.com/Linaro/odp/pull/395#discussion_r161865907 updated_at 2018-01-16 19:42:25
