* typedef struct { } ODP_ALIGN() test_t; is correct
* typedef struct ODP_ALIGN() {} test_t; is correct and
preferred from gcc standards
* typedef struct {} test_t ODP_ALIGN() discards align
Had segfaults on gcc-7 using thatSigned-off-by: Ilias Apalodimas [email protected] ----------------github------------------------ /** Email created from pull request 398 (apalos:align) ** https://github.com/Linaro/odp/pull/398 ** Patch: https://github.com/Linaro/odp/pull/398.patch ** Base sha: 77ff03881d844a9d6a4bc773086bd8aaecace541 ** Merge commit sha: c603837c88f6623aeccb807bbb19cbd91c4c0583 **/ ----------------/github------------------------ ----------------checkpatch.pl------------------------ WARNING: A patch subject line should describe the change not the tool that found it #5: Subject: [PATCH v2 1/2] checkpatch.pl: do not warn on odp aligh macros total: 0 errors, 1 warnings, 0 checks, 7 lines checked to_send-p-000.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ERROR: open brace '{' following function declarations go on the next line #999: FILE: test/validation/api/chksum/chksum.c:17: +static uint8_t ODP_ALIGNED(4) ip_hdr_test_vect[NUM_IP_HDR][IP_HDR_LEN] = { ERROR: open brace '{' following function declarations go on the next line #1008: FILE: test/validation/api/chksum/chksum.c:41: +static struct udp_test_vect_s ODP_ALIGNED(4) udp_test_vect[NUM_UDP] = { ERROR: open brace '{' following function declarations go on the next line #1017: FILE: test/validation/api/chksum/chksum.c:89: +static uint8_t ODP_ALIGNED(4) udp_test_vect_long[] = { total: 3 errors, 0 warnings, 0 checks, 760 lines checked to_send-p-001.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ----------------/checkpatch.pl------------------------
