Dmitry Eremin-Solenikov(lumag) replied on github web page:

example/m4/configure.m4
line 17
@@ -7,6 +7,22 @@ AC_ARG_ENABLE([test-example],
     [test_example=yes])
 AM_CONDITIONAL([test_example], [test x$test_example = xyes ])
 
+code_instrumentation=no
+AC_ARG_ENABLE([code-instrum],
+    [  --enable-code-instrum   enable code instrumentation support],
+    [if test x$enableval = xyes; then
+        code_instrumentation=yes
+    fi])
+
+PAPI_PATH=""
+AC_ARG_WITH([papi-path],
+AS_HELP_STRING([--with-papi-path=DIR   path to papi install directory]),
+    [PAPI_PATH="$withval"
+    code_instrumentation=yes],[])
+
+AC_SUBST([PAPI_PATH])


Comment:
Drop this alltogether. PAPI has pkg-config file, so no need to reinvent it.

> Dmitry Eremin-Solenikov(lumag) wrote:
> Use `PKG_CHECK_MODULES([PAPI], [papi-5], [code_instrumentation=yes])` here.


>> Dmitry Eremin-Solenikov(lumag) wrote:
>> `AS_HELP_STRING` here


>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>> Again, use `$(PAPI_LIBS)` here


>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Please restructure include flags:
>>>>  - Use `$(ODP_INCLUDES)` to get all ODP includes
>>>>  - Use `$(PAPI_CFLAGS)` here.


https://github.com/Linaro/odp/pull/443#discussion_r165803576
updated_at 2018-02-03 03:36:49

Reply via email to