----------------github------------------------
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
** https://github.com/Linaro/odp/pull/470
** Patch: https://github.com/Linaro/odp/pull/470.patch
** Base sha: af7be638ef9ac98bdb1f2e4917f152889eb1850f
** Merge commit sha: f30e7ae4157bae994d5734b8917d2dd31dbf201e
**/
----------------/github------------------------
----------------checkpatch.pl------------------------
WARNING: 'seperate' may be misspelled - perhaps 'separate'?
#8:
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#14:
platform/linux-generic/odp_crypto.c | 164 ++++++++++++++++++++++++++++++++++++
ERROR: open brace '{' following function declarations go on the next line
#54: FILE: platform/linux-generic/odp_crypto.c:322:
+static void do_pad_xor(uint8_t *out, const uint8_t *in, int len) {
ERROR: spaces required around that '=' (ctx:VxV)
#55: FILE: platform/linux-generic/odp_crypto.c:323:
+ int pos=0;
^
WARNING: Missing a blank line after declarations
#56: FILE: platform/linux-generic/odp_crypto.c:324:
+ int pos=0;
+ for (pos=1; pos <= 16; pos++, in++, out++) {
ERROR: spaces required around that '=' (ctx:VxV)
#56: FILE: platform/linux-generic/odp_crypto.c:324:
+ for (pos=1; pos <= 16; pos++, in++, out++) {
^
CHECK: Please use a blank line after function/struct/union/enum declarations
#65: FILE: platform/linux-generic/odp_crypto.c:333:
+}
+static void xor_block(aes_block res, const aes_block op) {
ERROR: open brace '{' following function declarations go on the next line
#65: FILE: platform/linux-generic/odp_crypto.c:333:
+static void xor_block(aes_block res, const aes_block op) {
CHECK: Alignment should match open parenthesis
#74: FILE: platform/linux-generic/odp_crypto.c:342:
+odp_crypto_alg_err_t aesxcbc_gen(odp_packet_t pkt,
+ const odp_crypto_packet_op_param_t *param,
WARNING: line over 80 characters
#89: FILE: platform/linux-generic/odp_crypto.c:357:
+ EVP_EncryptInit_ex(ctx, EVP_aes_128_ecb(), NULL, session->auth.key,
NULL);
CHECK: Avoid CamelCase: <EVP_EncryptInit_ex>
#89: FILE: platform/linux-generic/odp_crypto.c:357:
+ EVP_EncryptInit_ex(ctx, EVP_aes_128_ecb(), NULL, session->auth.key,
NULL);
CHECK: No space is necessary after a cast
#91: FILE: platform/linux-generic/odp_crypto.c:359:
+ xor_block(e, (const uint32_t*) data);
ERROR: "(foo*)" should be "(foo *)"
#91: FILE: platform/linux-generic/odp_crypto.c:359:
+ xor_block(e, (const uint32_t*) data);
WARNING: line over 80 characters
#92: FILE: platform/linux-generic/odp_crypto.c:360:
+ EVP_EncryptUpdate(ctx, (uint8_t *)e, &dummy_len, (uint8_t *)e,
sizeof(e));
CHECK: Avoid CamelCase: <EVP_EncryptUpdate>
#92: FILE: platform/linux-generic/odp_crypto.c:360:
+ EVP_EncryptUpdate(ctx, (uint8_t *)e, &dummy_len, (uint8_t *)e,
sizeof(e));
WARNING: braces {} are not necessary for any arm of this statement
#96: FILE: platform/linux-generic/odp_crypto.c:364:
+ if (len == AES_BLOCK_SIZE) {
[...]
+ else
[...]
CHECK: No space is necessary after a cast
#97: FILE: platform/linux-generic/odp_crypto.c:365:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16));
ERROR: "(foo*)" should be "(foo *)"
#97: FILE: platform/linux-generic/odp_crypto.c:365:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16));
ERROR: that open brace { should be on the previous line
#99: FILE: platform/linux-generic/odp_crypto.c:367:
+ else
+ {
ERROR: else should follow close brace '}'
#99: FILE: platform/linux-generic/odp_crypto.c:367:
+ }
+ else
CHECK: No space is necessary after a cast
#101: FILE: platform/linux-generic/odp_crypto.c:369:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
ERROR: "(foo*)" should be "(foo *)"
#101: FILE: platform/linux-generic/odp_crypto.c:369:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
CHECK: spaces preferred around that '*' (ctx:VxV)
#101: FILE: platform/linux-generic/odp_crypto.c:369:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
^
ERROR: trailing whitespace
#104: FILE: platform/linux-generic/odp_crypto.c:372:
+^IEVP_CIPHER_CTX_free(ctx);^I$
WARNING: space prohibited between function name and open parenthesis '('
#105: FILE: platform/linux-generic/odp_crypto.c:373:
+ memcpy (icv, hash_out, 12);
ERROR: trailing whitespace
#106: FILE: platform/linux-generic/odp_crypto.c:374:
+^I$
CHECK: Alignment should match open parenthesis
#112: FILE: platform/linux-generic/odp_crypto.c:380:
+odp_crypto_alg_err_t aesxcbc_check(odp_packet_t pkt,
+ const odp_crypto_packet_op_param_t *param,
ERROR: trailing whitespace
#123: FILE: platform/linux-generic/odp_crypto.c:391:
+^I$
ERROR: trailing whitespace
#127: FILE: platform/linux-generic/odp_crypto.c:395:
+^I$
WARNING: line over 80 characters
#134: FILE: platform/linux-generic/odp_crypto.c:402:
+ EVP_EncryptInit_ex(ctx, EVP_aes_128_ecb(), NULL, session->auth.key,
NULL);
CHECK: No space is necessary after a cast
#137: FILE: platform/linux-generic/odp_crypto.c:405:
+ xor_block(e, (const uint32_t*) data);
ERROR: "(foo*)" should be "(foo *)"
#137: FILE: platform/linux-generic/odp_crypto.c:405:
+ xor_block(e, (const uint32_t*) data);
WARNING: line over 80 characters
#138: FILE: platform/linux-generic/odp_crypto.c:406:
+ EVP_EncryptUpdate(ctx, (uint8_t *)e, &dummy_len, (uint8_t *)e,
sizeof(e));
WARNING: braces {} are not necessary for any arm of this statement
#142: FILE: platform/linux-generic/odp_crypto.c:410:
+ if (len == AES_BLOCK_SIZE) {
[...]
+ else
[...]
CHECK: No space is necessary after a cast
#143: FILE: platform/linux-generic/odp_crypto.c:411:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16));
ERROR: "(foo*)" should be "(foo *)"
#143: FILE: platform/linux-generic/odp_crypto.c:411:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16));
ERROR: that open brace { should be on the previous line
#145: FILE: platform/linux-generic/odp_crypto.c:413:
+ else
+ {
ERROR: else should follow close brace '}'
#145: FILE: platform/linux-generic/odp_crypto.c:413:
+ }
+ else
CHECK: No space is necessary after a cast
#147: FILE: platform/linux-generic/odp_crypto.c:415:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
ERROR: "(foo*)" should be "(foo *)"
#147: FILE: platform/linux-generic/odp_crypto.c:415:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
CHECK: spaces preferred around that '*' (ctx:VxV)
#147: FILE: platform/linux-generic/odp_crypto.c:415:
+ xor_block(e, (const uint32_t*) (session->auth.key + 16*2));
^
ERROR: trailing whitespace
#150: FILE: platform/linux-generic/odp_crypto.c:418:
+^IEVP_CIPHER_CTX_free(ctx);^I$
ERROR: trailing whitespace
#157: FILE: platform/linux-generic/odp_crypto.c:425:
+}^I$
ERROR: trailing whitespace
#168: FILE: platform/linux-generic/odp_crypto.c:436:
+^I$
WARNING: line over 80 characters
#176: FILE: platform/linux-generic/odp_crypto.c:444:
+ EVP_EncryptInit_ex(ctx, EVP_aes_128_ecb(), NULL,
session->p.auth_key.data, NULL);
WARNING: line over 80 characters
#178: FILE: platform/linux-generic/odp_crypto.c:446:
+ EVP_EncryptUpdate(ctx, session->auth.key, &dummy_len, (uint8_t *)kn[0],
16);
WARNING: line over 80 characters
#181: FILE: platform/linux-generic/odp_crypto.c:449:
+ EVP_EncryptUpdate(ctx, session->auth.key+16, &dummy_len, (uint8_t
*)kn[1], 16);
CHECK: spaces preferred around that '+' (ctx:VxV)
#181: FILE: platform/linux-generic/odp_crypto.c:449:
+ EVP_EncryptUpdate(ctx, session->auth.key+16, &dummy_len, (uint8_t
*)kn[1], 16);
^
ERROR: trailing whitespace
#182: FILE: platform/linux-generic/odp_crypto.c:450:
+^I$
ERROR: trailing whitespace
#184: FILE: platform/linux-generic/odp_crypto.c:452:
+^IEVP_EncryptUpdate(ctx, session->auth.key+16*2, &dummy_len, (uint8_t *)kn[2],
16);^I$
WARNING: line over 80 characters
#184: FILE: platform/linux-generic/odp_crypto.c:452:
+ EVP_EncryptUpdate(ctx, session->auth.key+16*2, &dummy_len, (uint8_t
*)kn[2], 16);
CHECK: spaces preferred around that '+' (ctx:VxV)
#184: FILE: platform/linux-generic/odp_crypto.c:452:
+ EVP_EncryptUpdate(ctx, session->auth.key+16*2, &dummy_len, (uint8_t
*)kn[2], 16);
^
CHECK: spaces preferred around that '*' (ctx:VxV)
#184: FILE: platform/linux-generic/odp_crypto.c:452:
+ EVP_EncryptUpdate(ctx, session->auth.key+16*2, &dummy_len, (uint8_t
*)kn[2], 16);
^
ERROR: trailing whitespace
#186: FILE: platform/linux-generic/odp_crypto.c:454:
+^IEVP_CIPHER_CTX_free(ctx);^I$
ERROR: Missing Signed-off-by: line(s)
total: 25 errors, 14 warnings, 16 checks, 212 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
to_send-p-000.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: 'seperate' may be misspelled - perhaps 'separate'?
#9:
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#16:
test/validation/api/crypto/test_vectors.h | 209 +++++++++++++++++++++++
WARNING: line over 80 characters
#117: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:1291:
+ return check_alg_support(ODP_CIPHER_ALG_NULL,
ODP_AUTH_ALG_AES_XCBC_MAC);
ERROR: trailing whitespace
#148: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:1502:
+^I^I^I^I check_alg_hmac_sha384),^I^I^I $
WARNING: line over 80 characters
#148: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:1502:
+ check_alg_hmac_sha384),
ERROR: trailing whitespace
#150: FILE: test/validation/api/crypto/odp_crypto_test_inp.c:1504:
+^I^I^I^I check_alg_hmac_sha384),^I$
ERROR: trailing whitespace
#263: FILE: test/validation/api/crypto/test_vectors.h:1284:
+^I^I^I 0x9c, 0x7e, 0xf4, 0x64, 0xf5, 0xa0, 0x1b, 0x47,^I^I $
WARNING: line over 80 characters
#263: FILE: test/validation/api/crypto/test_vectors.h:1284:
+ 0x9c, 0x7e, 0xf4, 0x64, 0xf5, 0xa0, 0x1b, 0x47,
ERROR: trailing whitespace
#291: FILE: test/validation/api/crypto/test_vectors.h:1312:
+^I^I^I 0x0a, 0xa6, 0x35, 0xd9, 0x47, 0xac, 0x9f, 0xeb, $
ERROR: trailing whitespace
#342: FILE: test/validation/api/crypto/test_vectors.h:1493:
+^I^I.digest = { 0x47, 0xf5, 0x1b, 0x45, 0x64, 0x96, 0x62, 0x15, $
ERROR: trailing whitespace
#381: FILE: test/validation/api/crypto/test_vectors.h:1532:
+^I^I.digest = { 0x47, 0xf5, 0x1b, 0x45, 0x64, 0x96, 0x62, 0x15, $
ERROR: Missing Signed-off-by: line(s)
total: 7 errors, 5 warnings, 0 checks, 371 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
to_send-p-001.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: 'seperate' may be misspelled - perhaps 'separate'?
#9:
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 12 lines checked
to_send-p-002.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: 'seperate' may be misspelled - perhaps 'separate'?
#8:
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 18 lines checked
to_send-p-003.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: 'seperate' may be misspelled - perhaps 'separate'?
#8:
/** Email created from pull request 470 (SonicwallYhe:api-next-seperate)
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#14:
platform/linux-generic/odp_crypto.c | 71 +++++++++++++-----------
WARNING: line over 80 characters
#63: FILE: platform/linux-generic/odp_crypto.c:361:
+ EVP_EncryptInit_ex(ctx, session->auth.evp_cipher, NULL,
session->auth.key, NULL);
WARNING: line over 80 characters
#102: FILE: platform/linux-generic/odp_crypto.c:404:
+ EVP_EncryptInit_ex(ctx, session->auth.evp_cipher, NULL,
session->auth.key, NULL);
CHECK: No space is necessary after a cast
#106: FILE: platform/linux-generic/odp_crypto.c:407:
+ xor_block(e, (const uint32_t *) data);
CHECK: Alignment should match open parenthesis
#134: FILE: platform/linux-generic/odp_crypto.c:428:
+static int process_aesxcbc_param(odp_crypto_generic_session_t *session,
+ const EVP_CIPHER *cipher)
CHECK: Alignment should match open parenthesis
#151: FILE: platform/linux-generic/odp_crypto.c:448:
+ EVP_EncryptInit_ex(ctx, session->auth.evp_cipher, NULL,
+ session->p.auth_key.data, NULL);
CHECK: Alignment should match open parenthesis
#155: FILE: platform/linux-generic/odp_crypto.c:451:
+ EVP_EncryptUpdate(ctx, session->auth.key,
+ &dummy_len, (uint8_t *)kn[0], 16);
CHECK: Alignment should match open parenthesis
#160: FILE: platform/linux-generic/odp_crypto.c:455:
+ EVP_EncryptUpdate(ctx, session->auth.key + 16,
+ &dummy_len, (uint8_t *)kn[4], 16);
CHECK: Alignment should match open parenthesis
#165: FILE: platform/linux-generic/odp_crypto.c:459:
+ EVP_EncryptUpdate(ctx, session->auth.key + 16 * 2,
+ &dummy_len, (uint8_t *)kn[8], 16);
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 4 warnings, 6 checks, 192 lines checked
to_send-p-004.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
----------------/checkpatch.pl------------------------
