Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

.travis.yml
line 4
@@ -58,6 +58,7 @@ env:
         - CONF="--enable-schedule-scalable"
         - CONF="--enable-dpdk-zero-copy"
         - CONF="--disable-static-applications"
+        - CONF="--enable-pcapng-support"


Comment:
@lumag Unfortunately flexibility comes at a price. We can't have untested 
features and if they are selectable at `configure` time then I don't see how to 
avoid this.

> Dmitry Eremin-Solenikov(lumag) wrote:
> I'm thinking about limiting variety of build options here. Not in your PR, 
> but there are just way tooo many


>> Dmitry Eremin-Solenikov(lumag) wrote:
>> And also it should be `_odp_pcapng_FOO`


>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>> `_odp_smth...`


>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Neat idea, but just put pcapng_prepare inside header and define it to 
>>>> empty val if ODP_PCAPNG is undefined.
>>>> Also if it returns an error, it should not require one to call 
>>>> pcapng_destroy() afterwards. Just make it clean up after itself in case of 
>>>> an error.


>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>> Just use one AC_DEFINE and check using `#ifdef` inside.


https://github.com/Linaro/odp/pull/488#discussion_r168909520
updated_at 2018-02-17 04:02:27

Reply via email to