Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: doc/users-guide/users-guide.adoc line 4 @@ -1198,4 +1198,6 @@ include::users-guide-tm.adoc[] include::users-guide-cls.adoc[] +include::users-guide-utilities-examples.adoc[]
Comment: Having this as a section of the User Guide is fine, but you need to add this file to the list in `doc/users-guide/Makefile.am` so that changes to it will cause the User Guide to be regenerated. > Bill Fischofer(Bill-Fischofer-Linaro) wrote: > This formats as __\<odp global pid\>-\<NIC name\>-flow-\<queue *number\>__ > > Is that what you wanted? >> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >> @lumag Unfortunately flexibility comes at a price. We can't have untested >> features and if they are selectable at `configure` time then I don't see how >> to avoid this. >>> Dmitry Eremin-Solenikov(lumag) wrote: >>> I'm thinking about limiting variety of build options here. Not in your PR, >>> but there are just way tooo many >>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>> And also it should be `_odp_pcapng_FOO` >>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>> `_odp_smth...` >>>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>>> Neat idea, but just put pcapng_prepare inside header and define it to >>>>>> empty val if ODP_PCAPNG is undefined. >>>>>> Also if it returns an error, it should not require one to call >>>>>> pcapng_destroy() afterwards. Just make it clean up after itself in case >>>>>> of an error. >>>>>>> Dmitry Eremin-Solenikov(lumag) wrote: >>>>>>> Just use one AC_DEFINE and check using `#ifdef` inside. https://github.com/Linaro/odp/pull/488#discussion_r168911146 updated_at 2018-02-17 04:02:27