Dmitry Eremin-Solenikov(lumag) replied on github web page:
platform/linux-generic/include/odp_internal.h
line 13
@@ -55,10 +56,13 @@ struct odp_global_data_s {
odp_cpumask_t control_cpus;
odp_cpumask_t worker_cpus;
int num_cpus_installed;
+ config_t libconfig; /*< Runtime config using libconfig */
+ uint8_t libconfig_enabled; /*< Runtime config enabled */
Comment:
Ideally we do not need this field. We should always return valid setting. Maybe
by allowing ODP modules to return default value.
> Dmitry Eremin-Solenikov(lumag) wrote:
> I'd prefer not to export config internals here, but rather have
> `_odp_config_lookup_int()`, `_odp_config_lookup_string()`, etc.
>> Dmitry Eremin-Solenikov(lumag) wrote:
>> Last line should not be necessary
>>> bogdanPricope wrote
>>> OFP is using a similar naming for the environment variable but with 'CONF'
>>> instead of 'CONFIG' ('OFP_CONF_FILE'). Will it makes sense to change the
>>> naming to avoid confusions: either 'ODP_CONF_FILE' in ODP or
>>> 'OFP_CONFIG_FILE' in OFP?
>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>> Do we really want to print this unconditionally? In any event shouldn't
>>>> this be `ODP_LOG()` here rather than `printf()`?
>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>> According to the [libconfig
>>>>> changelog](https://github.com/hyperrealm/libconfig/blob/master/ChangeLog)
>>>>> there are versions pre-1.0 (e.g., 0.9) which would fail this test. This
>>>>> needs to be reversed so that you use the newer form for v1.5 and higher
>>>>> levels:
>>>>> ```
>>>>> #if (LIBCONFIG_VER_MAJOR > 1 || (LIBCONFIG_VER_MAJOR == 1 &&
>>>>> LIBCONFIG_VER_MINOR >= 5)) ...
>>>>> ```
>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>> Does this have to be a hard dependency? Can we have this feature be
>>>>>> omitted (hardcoded defaults are used) if libconfig is not available?
https://github.com/Linaro/odp/pull/499#discussion_r170518104
updated_at 2018-02-26 08:22:22
