Martin Owens has proposed merging lp:~doctormo/loco-directory/bugfix-lp-625100 
into lp:loco-directory.

Requested reviews:
  loco-directory-dev (loco-directory-dev)
Related bugs:
  #625100 Team Page Should be cleaner than it currently is.
  https://bugs.launchpad.net/bugs/625100


Please accept these design changes to the team page.
-- 
https://code.launchpad.net/~doctormo/loco-directory/bugfix-lp-625100/+merge/33869
Your team loco-directory-dev is requested to review the proposed merge of 
lp:~doctormo/loco-directory/bugfix-lp-625100 into lp:loco-directory.
=== modified file 'loco_directory/media/css/newstyle.css'
--- loco_directory/media/css/newstyle.css	2010-08-23 09:14:06 +0000
+++ loco_directory/media/css/newstyle.css	2010-08-27 06:26:42 +0000
@@ -4,6 +4,9 @@
 a:visited {
 	color: #b12a10;
 }
+th.form-item-label {
+    vertical-align: top;
+}
 label {
     font-weight: bold;
     white-space: nowrap;

=== modified file 'loco_directory/templates/teams/team_detail.html'
--- loco_directory/templates/teams/team_detail.html	2010-08-23 08:18:37 +0000
+++ loco_directory/templates/teams/team_detail.html	2010-08-27 06:26:42 +0000
@@ -18,16 +18,14 @@
 
 {% block content %}
 <article class="minor-content alone">
-<h2>{{ team.name }}</a></h2>
+<h2><a href="https://launchpad.net/~{{ team.lp_name }}">{{ team.name }}</a></h2>
 
  <table>
     <tr>
         <th class="form-item-label" scope="row"><label>{% trans "Location:" %}</label></th>
         <td class="form-item-value">
             {% if team.countries.all %}
-                {% for country in team.countries.all %}{% if not forloop.first %}, {% endif %}{{ country.name }}{% endfor %}
-                {% if team.spr %}, {% trans team.spr %}{% endif %}
-                {% if team.city %}, {% trans team.city %}{% endif %}
+                {% for country in team.countries.all %}{% if not forloop.first %}, {% endif %}{{ country.name }}{% endfor %}{% if team.spr %}, {% trans team.spr %}{% endif %}{% if team.city %}, {% trans team.city %}{% endif %}
             {% else %}
 		        {% trans "None Specified" %}
             {% endif %}
@@ -43,15 +41,6 @@
             {% endif %}
         </td>
     </tr>
-	<tr>
-	  <th class="form-item-label" scope="row"><label>{% trans "Launchpad Page:" %}</label></th>
-	  <td class="form-item-value"><a href="https://launchpad.net/~{{ team.lp_name }}">{{ team.name }}</a></td>
-	</tr>
-
-        <tr>
-          <th class="form-item-label" scope="row"><label>{% trans "Launchpad Team Owner:" %}</label></th>
-          <td class="form-item-value"><a href="https://launchpad.net/~{{ team.owner }}">{{ team.owner }}</a></td>
-        </tr>
         
         {% if team.approved_date %}
           <tr>
@@ -66,13 +55,15 @@
           </tr>
         {% endif %}
         <tr>
-          <th class="form-item-label" scope="row"><label>{% trans "Provides Local Support:" %}</label></th>
+          <th class="form-item-label" scope="row"><label>{% trans "Local Support:" %}</label></th>
           <td class="form-item-value">{% if team.provides_support %}Yes{% else %}No{% endif %}</td>
         </tr>
         <tr>
-          <th class="form-item-label" scope="row"><label>{% trans "Launchpad Team Admin(s):" %}</label></th>
+          <th class="form-item-label" scope="row"><label>{% trans "Team Admin(s):" %}</label></th>
           <td class="form-item-value">{% for admin in team.admins.all %}
-				  <a href="https://launchpad.net/~{{ admin.lpid }}">{{ admin.lpid }}</a>{% if not forloop.last %},{% endif %}
+            {% ifequal team.owner admin.lpid %}
+              <strong><a href="https://launchpad.net/~{{ admin.lpid }}">{{ admin }}</a></strong>{% else %}
+              <a href="https://launchpad.net/~{{ admin.lpid }}">{{ admin }}</a>{% endifequal %}{% if not forloop.last %},{% endif %}
           {% endfor %}</td>
         </tr>
 

_______________________________________________
Mailing list: https://launchpad.net/~loco-directory-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~loco-directory-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to