On Aug 12, 2004, at 3:53 PM, c wrote:
I agree with you, Curt. But I think it's a good short term solution to help developers who are blocked with the current implementation.
The solution you refer to is surely the best one, but much work will be needed to achieve it. Consequently, we could deliver it later.
Regards,
I'll vote a +0.
I did more investigation that I can justify at the moment. The hardest problem seemed to be the dependency on helper/CriticalSection.h on config.h to define HAVE_PTHREAD. I don't see a cheap way to get that out of the header file.
I was a bit troubled by CriticalSection having its mutex and owningThread members public. Since there are accessors for them, I assume it was just an oversight to not add a "private:" before the #ifdef HAVE_PTHREAD. If the patch touches, criticalsection.h could you consider changing the visibility of those members.
Also, Christophe is not listed on the http://logging.apache.org/log4cxx/team.html. I assume that he should be.
The AUTHORS file lists Micha�l, but with a users.sourceforge.net domain. Should those addresses be updated? Should Christophe and I be added?
