> Which version and platform of C++ Builder were you using? We're using Borlanf C++ Builder 6 Enterprise on Windows 2000 but I guess the changes we made apply to any BCB6 on any Win32 platform...
> Could you provide > a short reason for each change or any observable bugs due to the > original code? I can guess if I have to, but it would be nice to have > your comments. Yes, of course. In fact, the changes I sent did not strictly concern BCB6 port for this time (I have some other changes in the pipe but I thought you might not want them to be applied straightforward as I did and I also thought this was enough for a first shot...). Here are the reason for each of them : fileappender.cpp : The name was passed instead of the option. As far as I can remember, I discovered this when I tried to set the threshold option (for instance) on a FileAppender through a configuration file and I realized it was not taken into account whereas it works for other appenders... patternparser.h + patternparser.cpp and rootcategory.h + rootcategory.cpp : BCB warns against methods that hide base class methods. I think these virtual methods intended to override the one declared in the base class and thus changed their signature in consequence. I didn't try to find any related bug though. src/stringtokenizer.cpp : I changed the delete to delete[] since the allocation is done through new[]. I know you know that having unrelated new/delete can cause memory troubles with some compilers. Hope it helps Regards Laurent R
